FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

forex_python.converter.RatesNotAvailableError: Currency Rates Source … by abhijit111093 · Pull Request #102 · MicroPyramid/forex-python · GitHub

forex_python.converter.RatesNotAvailableError: Currency Rates Source … - #102

Merged
abhijit111093 merged 1 commit into
masterfrom
Currency_Rates_Source_Not_Ready
Sep 2, 2021
Merged

forex_python.converter.RatesNotAvailableError: Currency Rates Source …#102
abhijit111093 merged 1 commit into
masterfrom
Currency_Rates_Source_Not_Ready

Conversation

Copy link
Copy Markdown
Contributor

…Not Ready issue fixed

abhijit111093 merged commit 0ca3add into master Sep 2, 2021

Copy link
Copy Markdown
Contributor

@abhijit111093 this change causes the tests on the master branch to fail

Leaving commented out code in a repository is also bad practice
Because it is unnecessary when using git (the old code can always be retrieved from the git history if required, so deleting is not a problem)
And it will confuse / mislead developers who when they read it will wonder why it's there, if it's planned to be returned etc.

Robbie-Palmer added a commit to Robbie-Palmer/forex-python that referenced this pull request Nov 6, 2021
…y_Rates_Source_Not_Ready"

This reverts commit 0ca3add, reversing
changes made to fcc62b7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL