FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added `workspaceContains:pyproject.toml` to activationEvents by BrandonLWhite · Pull Request #12056 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Added workspaceContains:pyproject.toml to activationEvents - #12056

Merged
Eric Snow (ericsnowcurrently) merged 2 commits into
microsoft:masterfrom
BrandonLWhite:workspaceContains-pyproject
Jun 23, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Added workspaceContains:pyproject.toml to activationEvents#12056
Eric Snow (ericsnowcurrently) merged 2 commits into
microsoft:masterfrom
BrandonLWhite:workspaceContains-pyproject

Conversation

Brandon White (BrandonLWhite) commented May 29, 2020 •
edited
Loading

Copy link
Copy Markdown

(for #4765)

This PR adds triggering off of 'pyproject.toml' in the workspace root to load the extension.

I'm hoping that using this standard file is easier to get merged vs. the "kitchen-sink" approach that has stalled another PR due to debates and disagreements.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

Kartik Raj (karrtikr) reviewed Jun 2, 2020
View reviewed changes

Kartik Raj (karrtikr) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the PR. Don't forget to add a news entry.

Eric Snow (ericsnowcurrently) reviewed Jun 3, 2020
View reviewed changes

Eric Snow (ericsnowcurrently) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What issue is this for? We need a bit more discussion on the topic of file-based activation events (in package.json). For example, there are other files that are just as valid as markers for Python projects (requirements.txt, pytest.ini, etc.). Furthermore, note that we don't already have "workspaceContains:**/*.py" in the list. So a bit more discussion in a corresponding issue would be helpful.

Brandon White (BrandonLWhite) commented Jun 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Author

Eric Snow (@ericsnowcurrently) I specifically wanted to concentrate just on the pyproject.toml since that is a PEP standard file. There is another PR that has a wide variety of files it aims to support, but because of that appears to be stalled for several months due to disagreements that may never be resolved. In the meantime, VSCode continues to have a sub-par Python user experience because the extension isn't even activated until you open a .py file in the editor.

Brandon White (BrandonLWhite) commented Jun 3, 2020

Copy link
Copy Markdown
Author

Relates to Issue #4765

Eric Snow (ericsnowcurrently) commented Jun 3, 2020

Copy link
Copy Markdown

Understood. I've left a comment on #4765.

Deleted user (ghost) commented Jun 11, 2020 •
edited by ghost
Loading

Copy link
Copy Markdown


All CLA requirements met.

sonarqubecloud Bot commented Jun 11, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

Brandon White (BrandonLWhite) commented Jun 19, 2020

Copy link
Copy Markdown
Author

Can we please move forward with this and merge? If not, please advise as to what is blocking.

Eric Snow (ericsnowcurrently) mentioned this pull request Jun 22, 2020
Closed

Eric Snow (ericsnowcurrently) commented Jun 22, 2020

Copy link
Copy Markdown

I'm fine with the PR (though I'd suggest adding setup.py to it). However, I'm double-checking with someone else first. Thanks for your patience.

Eric Snow (ericsnowcurrently) approved these changes Jun 23, 2020
View reviewed changes

Eric Snow (ericsnowcurrently) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

We'll also look at adding workspaceContains:setup.py in the near future.

Eric Snow (ericsnowcurrently) merged commit 3eb1325 into microsoft:master Jun 23, 2020

Eric Snow (ericsnowcurrently) commented Jun 23, 2020

Copy link
Copy Markdown

Thanks Brandon White (@BrandonLWhite)!

Eric Snow (ericsnowcurrently) commented Jun 23, 2020

Copy link
Copy Markdown

And sorry that took so long to sort out. Thanks for your patience. 😄

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Kartik Raj (karrtikr) Awaiting requested review from karrtikr
1 more reviewer
Eric Snow (ericsnowcurrently) ericsnowcurrently approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL