FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Activate if workspace have Python-related files by bytemain · Pull Request #10856 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Activate if workspace have Python-related files - #10856

Closed
Jiacheng (bytemain) wants to merge 6 commits into
microsoft:mainfrom
bytemain:master
ConversationCommits (6)ChecksFiles changed
Closed

Activate if workspace have Python-related files#10856
Jiacheng (bytemain) wants to merge 6 commits into
microsoft:mainfrom
bytemain:master

Conversation

Jiacheng (bytemain) commented Mar 30, 2020

Copy link
Copy Markdown

close: #4765

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

Microsoft Contribution License Agreements (msftclas) commented Mar 30, 2020 •
edited
Loading

Copy link
Copy Markdown


All CLA requirements met.

Codecov (codecov-io) commented Mar 30, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #10856 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10856      +/-   ##
==========================================
- Coverage   60.69%   60.66%   -0.03%     
==========================================
  Files         580      580              
  Lines       31512    31525      +13     
  Branches     4480     4479       -1     
==========================================
- Hits        19125    19124       -1     
- Misses      11419    11429      +10     
- Partials      968      972       +4
Impacted Files Coverage Δ
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
...interpreter/locators/services/KnownPathsService.ts 49.05% <0.00%> (-1.93%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️
src/client/common/featureDeprecationManager.ts 40.90% <0.00%> (-0.63%) ⬇️
...rpreter/locators/services/baseVirtualEnvService.ts 28.07% <0.00%> (-0.51%) ⬇️
src/client/linters/lintingEngine.ts 20.00% <0.00%> (-0.21%) ⬇️
.../client/testing/common/managers/baseTestManager.ts 45.13% <0.00%> (-0.18%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4fab2...492fe83. Read the comment docs.

Kartik Raj (karrtikr) reviewed Mar 30, 2020
View reviewed changes

Kartik Raj (karrtikr) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the PR! Can you please include all the files mentioned the issue, including comments. This for instance.

Also please thank yourself in the news entry. :)

Rich Chiodo (rchiodo) reviewed Mar 30, 2020
View reviewed changes
Comment thread package.json

sonarqubecloud Bot commented Mar 31, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

Jiacheng (bytemain) commented Mar 31, 2020

Copy link
Copy Markdown
Author

There's so much stuff in Python community 😆

Karthik Nadig (karthiknadig) commented Mar 31, 2020

Copy link
Copy Markdown
Member

Page Not Found (@lengthmin) Thank you for the updates. We might want to wrap this in an experiment. See discussion on #4765.

Eric Snow (ericsnowcurrently) mentioned this pull request Apr 1, 2020
Merged
Brandon White (BrandonLWhite) mentioned this pull request Jun 3, 2020
Merged
10 tasks
microsoft-github-updates Bot changed the base branch from master to main September 3, 2020 21:07
Brett Cannon (brettcannon) requested changes Nov 10, 2020
View reviewed changes

Brett Cannon (brettcannon) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please only update for pyproject.toml.

Jiacheng (bytemain) commented Nov 11, 2020

Copy link
Copy Markdown
Author

Brett Cannon (@brettcannon) it seem that this feature has already merged into main branch

should I close this pr?

Brett Cannon (brettcannon) commented Nov 11, 2020

Copy link
Copy Markdown
Member

Sorry, I forgot we put that change in already.

Yeah, unfortunately we have to balance triggering the extension with the fact that a lot of people only use Python occasionally and thus don't want to have it launch just because they run Python once every two months or something. Thanks for trying, though.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Rich Chiodo (rchiodo) rchiodo left review comments
Brett Cannon (brettcannon) brettcannon requested changes
+1 more reviewer
Kartik Raj (karrtikr) karrtikr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

Kartik Raj (karrtikr)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If I have Python-related files in my workspace, automatically activate the extension

7 participants

Back | FazBrowse Home | New Git URL