Fix JIT compilation for methods on generic types - #298
Open
JBou wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Update `FxCoreBaseRuntime.Compile` to pass generic type arguments to `RuntimeHelpers.PrepareMethod` when the method is declared on a generic type. This ensures that the runtime prepares the correct method instantiation. Add unit tests `Test_GenericClassDetour` and `Test_GenericClassDetourWithoutGenericParameter` to `DetourTest` to verify detours on generic types.
nike4613
requested changes
Mar 10, 2026
nike4613
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
We do not support patching generics at all at the moment, and while I'm perfectly willing to take improvements in this area, this is an extremely difficult area, and I doubt this fixes the fundamental problem.
Sorry, something went wrong.
Comment thread
src/MonoMod.UnitTest/RuntimeDetour/DetourTest.cs
| Assert.Equal(1, obj1.GetDouble()); | ||
| Assert.Equal(1, obj2.GetDouble()); | ||
|
|
||
| var detour1 = DetourFactory.Current.CreateDetour(originalMethod1, replacement1); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This should be in a using block.
Sorry, something went wrong.
Comment thread
src/MonoMod.Core/Platforms/Runtimes/FxCoreBaseRuntime.cs
Comment on lines
+377
to
+386
| else | ||
| { | ||
| RuntimeHelpers.PrepareMethod(handle); | ||
| } |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
If we're going to try to do any handling of generics, it should be complete, and deal with method instantiations properly as well. As such, the generic type param list construction should probably be its own helper (maybe in utils? There may also already be an appropriate helper somewhere in the JIT hook logic.)
Sorry, something went wrong.
This comment has been minimized.
Copy link
Copy Markdown
Contributor
Test Results
Failing runs❌ MonoMod.UnitTest.DetourTest.Test_GenericClassDetour❌ MonoMod.UnitTest.DetourTest.Test_GenericClassDetourWithoutGenericParameter
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Requested changes must be addressed to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, I had to stay on Harmony 2.2.2, because patches on generic types where not working with Harmony 2.3 using MonoMod.Core anymore. This PR would allow to patch them again. I verified in our production app, and am able to apply the patches again.
Changes:
Update FxCoreBaseRuntime.Compile to pass generic type arguments to RuntimeHelpers.PrepareMethod when the method is declared on a generic type. This ensures that the runtime prepares the correct method instantiation.
Add unit tests Test_GenericClassDetour and Test_GenericClassDetourWithoutGenericParameter to DetourTest to verify detours on generic types.