build: disable C4267 conversion compiler warning · MoonBall/node@97ebdf3 · GitHub

MoonBall / node Public

forked from nodejs/node

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 97ebdf3

Browse filesBrowse the repository at this point in the historyBrowse files

bnoordhuis

committed

build: disable C4267 conversion compiler warning

Disable "warning C4267: conversion from 'size_t' to 'int', possible loss of data". Many originate from our dependencies and their sheer number drowns out other, more legitimate warnings. PR-URL: nodejs#11205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

1 parent c38b6d2 commit 97ebdf3
Copy full SHA for 97ebdf3

1 file changed

+4Lines changed: 4 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• common.gypi

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -188,6 +188,10 @@
188	188	'BufferSecurityCheck': 'true',
189	189	'ExceptionHandling': 0, # /EHsc
190	190	'SuppressStartupBanner': 'true',
	191	+ # Disable "warning C4267: conversion from 'size_t' to 'int',
	192	+ # possible loss of data". Many originate from our dependencies
	193	+ # and their sheer number drowns out other, more legitimate warnings.
	194	+ 'DisableSpecificWarnings': ['4267'],
191	195	'WarnAsError': 'false',
192	196	},
193	197	'VCLibrarianTool': {

0 commit comments

Comments

0 (0)