build: disable C4267 conversion compiler warning - #11205
Merged
bnoordhuis merged 1 commit intoFeb 9, 2017
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
Feb 6, 2017
cjihrig
approved these changes
Feb 6, 2017
mhdawson
approved these changes
Feb 7, 2017
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with a question. Is it possible to disable for specific files/directories or is it all or nothing ?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Not on a file or directory basis but it can be set on a per-target basis. |
Sorry, something went wrong.
Disable "warning C4267: conversion from 'size_t' to 'int', possible loss of data". Many originate from our dependencies and their sheer number drowns out other, more legitimate warnings. PR-URL: nodejs#11205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
bnoordhuis
force-pushed
the
msvs-disable-c4267
branch
from
e528ff1 to
97ebdf3
Compare
February 9, 2017 13:46
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 9, 2017
Disable "warning C4267: conversion from 'size_t' to 'int', possible loss of data". Many originate from our dependencies and their sheer number drowns out other, more legitimate warnings. PR-URL: nodejs#11205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Disable "warning C4267: conversion from 'size_t' to 'int', possible loss of data". Many originate from our dependencies and their sheer number drowns out other, more legitimate warnings. PR-URL: nodejs#11205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Disable "warning C4267: conversion from 'size_t' to 'int', possible loss of data". Many originate from our dependencies and their sheer number drowns out other, more legitimate warnings. PR-URL: nodejs#11205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Disable "warning C4267: conversion from 'size_t' to 'int', possible loss of data". Many originate from our dependencies and their sheer number drowns out other, more legitimate warnings. PR-URL: #11205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Disable "warning C4267: conversion from 'size_t' to 'int', possible loss of data". Many originate from our dependencies and their sheer number drowns out other, more legitimate warnings. PR-URL: #11205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Disable "warning C4267: conversion from 'size_t' to 'int', possible loss of data". Many originate from our dependencies and their sheer number drowns out other, more legitimate warnings. PR-URL: #11205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Disable "warning C4267: conversion from 'size_t' to 'int', possible loss of data". Many originate from our dependencies and their sheer number drowns out other, more legitimate warnings. PR-URL: #11205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable "warning C4267: conversion from 'size_t' to 'int', possible
loss of data". Many originate from our dependencies and their sheer
number drowns out other, more legitimate warnings.
CI: https://ci.nodejs.org/job/node-test-pull-request/6246/