FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Show all signature matches when trying to bucket a crash. by jschwartzentruber · Pull Request #593 · MozillaSecurity/FuzzManager · GitHub

  1. MozillaSecurity
  2. FuzzManager

Repository navigation

Show all signature matches when trying to bucket a crash. - #593

Draft
jschwartzentruber wants to merge 1 commit into
MozillaSecurity:masterfrom
jschwartzentruber:show-all-sig-matches
ConversationCommits (1)ChecksFiles changed
Draft

Show all signature matches when trying to bucket a crash.#593
jschwartzentruber wants to merge 1 commit into
MozillaSecurity:masterfrom
jschwartzentruber:show-all-sig-matches

Conversation

jschwartzentruber commented Feb 4, 2020

Copy link
Copy Markdown
Contributor

Searching for matching buckets for an unbucketed crash only shows "good" matches, where "good" is fairly arbitrary. Instead show all matches (ordered by quality of the match), and let the user decide.

[crashmanager] Show all signature matches when trying to bucket a crash.
efd2c59 
Searching for matching buckets for an unbucketed crash only shows "good"
matches, where "good" is fairly arbitrary. Instead show all matches
(ordered by quality of the match), and let the user decide.
jschwartzentruber self-assigned this Feb 4, 2020
jschwartzentruber changed the title [crashmanager] Show all signature matches when trying to bucket a crash. Show all signature matches when trying to bucket a crash. Feb 4, 2020

codecov Bot commented Feb 4, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 5.40541% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.01%. Comparing base (a2d82bf) to head (efd2c59).
⚠️ Report is 502 commits behind head on master.

Files with missing lines Patch % Lines
server/crashmanager/views.py 5.40% 35 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   66.02%   66.01%   -0.01%     
==========================================
  Files          80       80              
  Lines        7976     7975       -1     
==========================================
- Hits         5266     5265       -1     
  Misses       2710     2710

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jschwartzentruber commented Jun 10, 2020

Copy link
Copy Markdown
Contributor Author

@choller pointed out that this was a necessary optimization because for many signatures, searching all buckets would be unacceptably slow.

needs further thought to see if both goals can be achieved. (performant and showing more matches)

jschwartzentruber marked this pull request as draft June 10, 2020 14:09

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

choller Awaiting requested review from choller

At least 1 approving review is required to merge this pull request.

Assignees

jschwartzentruber

Labels

crashmanager enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL