Repository navigation
Allow calc() function inside rgba() and hsla() - #259
thomashigginbotham wants to merge 1 commit into
Conversation
Sorry, something went wrong.
This fix allows the alpha value of rgba() and hsla() functions to accept a calc() function.
| . "\n" | ||
| . '#variables-alpha {background-color: rgba(var(--some-rgb),.1);' | ||
| . 'background-color: rgba(var(--some-rg),255,.1);background-color: hsla(var(--some-hsl),.1);}', | ||
| . 'background-color: rgba(var(--some-rg),255,.1);background-color: hsla(var(--some-hsl),.1);}' |
There was a problem hiding this comment.
Soon, I'd like to split up the tests so that each test method is only about one piece of behavior, not multiple things mashed together. You can help my work by moving the test for the new behavior into a new test. Thanks!
Sorry, something went wrong.
There was a problem hiding this comment.
Not sure if I'll have time for awhile. I needed a quick fix for the calc() issue, and I saw the necessary changes were simple enough. I didn't dig too far into the unit testing, but I agree that it would be better to break them up into separate tests.
Sorry, something went wrong.
There was a problem hiding this comment.
@thomashigginbotham If you don't have time now, then let's keep this PR as it is, and then I will split up the test later. Kudos to you for covering your change with a test, by the way! ❤️
Sorry, something went wrong.
Reviewers
At least 1 approving review is required to merge this pull request.
This fix allows the alpha value of rgba() and hsla() functions to accept
a calc() function.