Unify camera management API with JS code base. - #239
Open
EMaksymenko wants to merge 9 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Calculate correct GL near clip distance and limit Navigator to avoid terrain collisions. Fix lookAt point calculation for gesture begin - take terrain altitude in consideration. Add terrain elevation output into example application. Navigator tests were commented as it is now dependent on context.
Add UTM, MGRS, GARS and LatLon graticule (ported from Java). Add MGRSGraticuleActivity to examples.
…Navigator, Camera and LookAt. Move field of view attribute into Camera. Deprecate Navigator and use direct Camera control instead. Use two-fingers tilt. Do not change heading on tilt. Set gesture interpret distance based on Android screen density instead of hard-coded pixels. Add additional zoomIn, zoomOut and resetOrientation commands to BasicWorldWindowController. Add secondary mouse button tilt support to BasicWorldWindowController. Remove code which never executes due to a bug in WWMath.
PJHogan
previously approved these changes
Apr 26, 2022
EMaksymenko
force-pushed
the
feature/refactor-camera
branch
from
3bd64d2 to
90ea5c6
Compare
April 26, 2022 18:43
EMaksymenko
force-pushed
the
feature/refactor-camera
branch
from
90ea5c6 to
29d100d
Compare
April 26, 2022 19:19
EMaksymenko
force-pushed
the
feature/refactor-camera
branch
from
9c56c0e to
4a7f670
Compare
June 10, 2022 11:48
PJHogan
previously approved these changes
Aug 4, 2022
EMaksymenko
force-pushed
the
feature/refactor-camera
branch
2 times, most recently
from
244044b to
16c724e
Compare
August 4, 2022 19:56
EMaksymenko
force-pushed
the
feature/refactor-camera
branch
from
b6bee11 to
56c4e8d
Compare
August 4, 2022 20:12
PJHogan
previously approved these changes
Aug 27, 2022
EMaksymenko
force-pushed
the
feature/refactor-camera
branch
from
e495778 to
53a230b
Compare
September 1, 2022 15:23
EMaksymenko
force-pushed
the
feature/refactor-camera
branch
from
4f8164b to
1859a8f
Compare
October 17, 2022 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Deprecate Navigator class and control Camera directly like in JS codebase.
Move LookAt point conversion routine into Camera class.
Move field of view into Camera class.
Use Position object instead of separate latitude, longitude and altitude attributes in Camera and LookAt.
Use two-fingers tilt. Do not change heading on tilt.
Use gesture interpret distance in DP respecting screen density instead of PX.
Update documentation templates according to new API.
Add additional zoomIn, zoomOut and resetOrientation commands to BasicWorldWindowController.
Add secondary mouse button tilt support to BasicWorldWindowController.
Remove code which never executes due to a bug in WWMath.
Why Should This Be In Core?
Make a step to API unification with JS code base and improve gestures UX.
Benefits
Improve UX by using only two fingers gesture detection.
Improve performance.
Simplify Camera control.
Potential Drawbacks
May be partially incompatible with old customer applications.