Fix GeoPackage support implementation. - #243
Open
EMaksymenko wants to merge 12 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…el set sector used.
- Add support of local tile origin based on tile matrix set extent instead of full sphere origin. - Add surface image name based on content identifier. - Change level set sector initialization based on tile matrix set extent instead of content extent. - Change first level tile delta and number of levels calculation based on tile matrix zoom levels. - Fix row calculation in tile factory.
…ng levels size in case of gaps in levels numeration.
PJHogan
previously approved these changes
Apr 23, 2022
EMaksymenko
force-pushed
the
feature/geopackage
branch
from
fba5af4 to
99d1eab
Compare
July 17, 2022 19:50
…eopackage # Conflicts: # worldwind/src/main/java/gov/nasa/worldwind/layer/mercator/MercatorImageTile.java # worldwind/src/main/java/gov/nasa/worldwind/layer/mercator/MercatorSector.java # worldwind/src/main/java/gov/nasa/worldwind/layer/mercator/MercatorTiledImageLayer.java # worldwind/src/main/java/gov/nasa/worldwind/render/ImageRetriever.java # worldwind/src/main/java/gov/nasa/worldwind/render/ImageSource.java
PJHogan
approved these changes
Jul 31, 2022
PJHogan
previously approved these changes
Jul 31, 2022
PJHogan
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Grazie Mille!!!
Sorry, something went wrong.
EMaksymenko
force-pushed
the
feature/geopackage
branch
from
da4a778 to
41e12a0
Compare
August 7, 2022 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Basic GeoPackage implementation does not support level sets started not in -90, -180 coordinates, but according standard any external system exports GeoPackage files with the tile origin equals south west corner of visible tile set.
That's why GeoPackage requires following improvements:
General API requires following improvements:
This PR is based on Mercator PR #242 due to this fix also related to MercatorTile calculations.
Why Should This Be In Core?
Support of GeoPackage files exported from ArcGis or GlobalMapper is not possible without this improvements.
Now GeoPackage works only with WorldWind test example, which was made with violation of GeoPackage specification requirements. Other words GeoPackage implementation is wrong now.
Benefits
Adding correct support of EPSG 4326 GeoPackage offline cache.
Potential Drawbacks
None. Backward compatible with current incorrect GeoPackage example.