Mgrs fix - #157
Open
gbburkhardt wants to merge 10 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
case for file extension
case for file extension
…nd build instructions. Change GDAL native library loader to work with multiple JNI native libraries, as is produced by the standard GDAL build.
…wig/java/makefile.vc to delete 'org' directory during clean since it's a build product; confusion can result if it's not deleted when switching between swig versions
… previous didn't match Linux because different swig versions were used. Update source and javadoc files using source generated by Swig 3.
… haCndling of extreme southern latitude (zone 0) conversions following Geotrans 3.7 for guidance: should give Lat: -89.345400 deg, Lon: -48.930600 deg ==> MGRS: AZN 45208 47747
This was referenced Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fix two problems:
a) Index out of bounds error due to typo in convertMGRSToUPS; clearly the index should have been 1 instead of 12.
b) Conversions from geodetic to MGRS would fail for low southern latitudes (zone 0). Geotrans 3.7 has this problem fixed. The WorldWind conversion code was derived from NGA's Geotrans. Test case:
Lat: -89.345400 deg, Lon: -48.930600 deg ==> MGRS: AZN 45208 47747
Why Should This Be In Core?
Bug fix
Benefits
Correct conversion from geodetic to MGRS
Potential Drawbacks
Applicable Issues