Partial fix of #195 - #218
Open
nicolas-van wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
Is this ever going to get implemented? This issue still exists years later. |
Sorry, something went wrong.
PJHogan
approved these changes
Mar 3, 2022
PJHogan
approved these changes
Mar 3, 2022
PJHogan
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Partial fix of issue #195 . Allows to resize the World Window according to Windows's scaling factor.
Why Should This Be In Core?
Because issue #195 is a problematic bug.
Benefits
It partially fixes issue #195. The fix is partial because it works only on program startup. If Windows's scaling factor is changed during execution issue #195 still reproduces. This is not ideal but still better than encountering that bug systematically.
Potential Drawbacks
Not that I know of.
Applicable Issues
#195
Comments
Thanks to @thwe74 for this solution.