Fix PointPlacemark pitch issue - #241
Open
EMaksymenko wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Prevent tilted PointPlacemark clipping (NASAWorldWind#151). Make rotation and tilting around specified offset point instead of image center.
EMaksymenko
force-pushed
the
fix/placemark-pitch
branch
from
d68482b to
843d22f
Compare
February 20, 2022 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds maximum diagonal size of placemark texture value into depth range of glOrtho, the similar way as CompassLayer do for Compass texture tilt.
It also fix rotation and tilting of PointPlacemark around specified offset point instead of rotation around center.
Why Should This Be In Core?
Bug should be fixed to make correct PointPlacemark tilt and rotation functionality.
Benefits
Placemarks will be correctly tilted and rotated without graphical glitches.
Potential Drawbacks
None.
Applicable Issues
#151