FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

run CI only on push/PR to main by sjvrijn · Pull Request #330 · NLeSC/python-template · GitHub

run CI only on push/PR to main - #330

Merged
egpbos merged 4 commits into
mainfrom
CI-only-on-main
Jan 31, 2023
Merged

run CI only on push/PR to main#330
egpbos merged 4 commits into
mainfrom
CI-only-on-main

Conversation

sjvrijn commented Jan 30, 2023

Copy link
Copy Markdown
Contributor

Description
As noticed by @BSchilperoort, the CI currently runs twice when new commits are pushed to a PR. This can be limited to only run on the main branch itself or PRs to main.

egpbos commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

This is great, thanks!

One small additional request: could you perhaps remove the line with types: [opened, synchronize, reopened]? It is superfluous, because those types are already the default (see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request).

Ready to merge after that, afaic.

egpbos commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

Oh, actually, the markdown-link-check action has the same issue... Would be super nice if that was fixed too :D

sjvrijn commented Jan 31, 2023

Copy link
Copy Markdown
Contributor Author

Should the cffconvert then also be limited to only run on push/PR to main?

egpbos commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

No cffconvert is already very specific, only runs when the cff file is updated.

Lgtm!

egpbos merged commit a1cc388 into main Jan 31, 2023

egpbos commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

Thanks for both these great PRs!

sjvrijn deleted the CI-only-on-main branch October 27, 2023 20:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL