FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add read/write permissions to allow issue creation by bvreede · Pull Request #340 · NLeSC/python-template · GitHub

add read/write permissions to allow issue creation - #340

Merged
egpbos merged 2 commits into
mainfrom
action-permissions-332
Jul 11, 2023
Merged

add read/write permissions to allow issue creation#340
egpbos merged 2 commits into
mainfrom
action-permissions-332

Conversation

bvreede commented Apr 7, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Adding permissions to the workflow allows issues to be created.

See the first few lines of the action usage at https://github.com/JasonEtco/create-an-issue

I made this change in my own project, which fixed permissions to create issues, but still failed when deleting them.

This is fixed when also giving write permissions for content; see this action run.

Closes #332

bvreede requested a review from lyashevska April 7, 2023 09:11

bvreede commented Apr 7, 2023

Copy link
Copy Markdown
Contributor Author

Failing windows tests still failing (see #326) >.<

egpbos commented Jun 8, 2023

Copy link
Copy Markdown
Collaborator

Why is it write + write here? In the example you linked to, you only used read + write.

@lyashevska does this fix your issue?

bvreede commented Jul 7, 2023

Copy link
Copy Markdown
Contributor Author

@egpbos apologies for the late reply. No, I needed to set

permissions:
  contents: write
  issues: write

for the workflow to be able to run successfully, and be able to both create the issues, and subsequently delete the template files.

See this file in the commit where the workflow ran completely.

egpbos commented Jul 11, 2023

Copy link
Copy Markdown
Collaborator

Clear, LGTM!

egpbos merged commit b261530 into main Jul 11, 2023
sjvrijn deleted the action-permissions-332 branch May 3, 2024 22:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read and write permissions to GITHUB_TOKEN in a new organisation are required for next_steps workflow

2 participants


Back | FazBrowse Home | New Git URL