Mention the guide in contribution guidelines and pull request template - #371
Merged
egpbos merged 2 commits intoJan 10, 2024
Merged
Mention the guide in contribution guidelines and pull request template#371egpbos merged 2 commits into
egpbos merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
egpbos
reviewed
Jan 10, 2024
egpbos
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Great idea. Just a slight suggestion to keep the contribution barrier low.
Sorry, something went wrong.
Comment thread
CONTRIBUTING.md
Outdated
Co-authored-by: Patrick Bos <egpbos@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator
|
Awesome, thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the contribution guidelines so the Python chapter from the guide is mentioned. Also add checkboxes to the pull request template. This should prevent the template from getting out of sync with what we recommend in the guide.