FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bumpversion bug by f-hafner · Pull Request #377 · NLeSC/python-template · GitHub

Bumpversion bug - #377

Merged
sjvrijn merged 2 commits into
NLeSC:mainfrom
f-hafner:bumpversion-bug
Apr 22, 2024
Merged

Bumpversion bug#377
sjvrijn merged 2 commits into
NLeSC:mainfrom
f-hafner:bumpversion-bug

Conversation

Copy link
Copy Markdown
Contributor

Description

There has been a breaking change in bumpy-my-version. Instead of bump-my-version major, you need to do bump-my-version bump major, which I fixed in the tests and in the README.dev.md for the generated package.

See https://github.com/callowayproject/bump-my-version/blob/master/CHANGELOG.md#0190-2024-03-12

Instructions to review the pull request

Create a python-template-test repo on GitHub (will be overwritten if existing)

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
cookiecutter -c bumpversion-bug https://github.com/f-hafner/python-template
# Fill with python-template-test info
cd python-template-test
git init
git add --all
git commit -m "First commit"
git remote add origin https://github.com/<you>/python-template-test
git push -u origin main -f
python -m venv env
source env/bin/activate
python -m pip install --upgrade pip setuptools
python -m pip install '.[dev,publishing]'

f-hafner mentioned this pull request Mar 22, 2024
2 tasks

sjvrijn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

sjvrijn commented Apr 22, 2024

Copy link
Copy Markdown
Contributor

Markdown link checker only failed on a link that is now working again, merging

sjvrijn merged commit 704a9b4 into NLeSC:main Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL