FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enable quiet mode for markdown link checker by sjvrijn · Pull Request #385 · NLeSC/python-template · GitHub

Enable quiet mode for markdown link checker - #385

Merged
sjvrijn merged 2 commits into
mainfrom
262-reduce-link-checker-verbosity
Aug 13, 2024
Merged

Enable quiet mode for markdown link checker#385
sjvrijn merged 2 commits into
mainfrom
262-reduce-link-checker-verbosity

Conversation

sjvrijn commented May 5, 2024

Copy link
Copy Markdown
Contributor

Description

Enables the 'use-quiet-mode' setting in the markdown link checker to only show broken links

Fixes #262

sjvrijn force-pushed the 262-reduce-link-checker-verbosity branch 2 times, most recently from e5577e9 to 2c2e446 Compare May 6, 2024 09:10
sjvrijn requested a review from Cmurilochem August 1, 2024 18:25

Copy link
Copy Markdown

Hi @sjvrijn. I will have some time on Friday to have a look at it. Sorry for the late feedback.

Cmurilochem left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @sjvrijn. As promised, I tested it locally with act and its works as expected. Good job!

I will approve it. But one question: Wouldn't it also be convenient to silent the markdown link checker here ?

This is up to up!

Thanks once again,
Best,
Carlos

sjvrijn force-pushed the 262-reduce-link-checker-verbosity branch from 2c2e446 to df96ae2 Compare August 13, 2024 12:49

sjvrijn commented Aug 13, 2024

Copy link
Copy Markdown
Contributor Author

@Cmurilochem Good point, thanks for noticing!

sjvrijn merged commit df96ae2 into main Aug 13, 2024
sjvrijn deleted the 262-reduce-link-checker-verbosity branch August 13, 2024 15:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make link checker less verbose

2 participants


Back | FazBrowse Home | New Git URL