FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

469-Make zenodo optional by lyashevska · Pull Request #520 · NLeSC/python-template · GitHub

469-Make zenodo optional - #520

Merged
lyashevska merged 15 commits into
mainfrom
469-zenodo
Aug 22, 2024
Merged

469-Make zenodo optional#520
lyashevska merged 15 commits into
mainfrom
469-zenodo

Conversation

lyashevska commented Aug 21, 2024
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This PR makes zenodo integration optional.

Related issues:

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Test 1:

Step-1:
Run the command below and say 'yes' to zenodo question

copier copy --vcs-ref 469-zenodo https://github.com/nlesc/python-template test_yes

Step-2:
Run the command below and say 'no' to zenodo question

copier copy --vcs-ref 469-zenodo https://github.com/nlesc/python-template test_no

What to check:
You should see the files below only when you say 'yes':

  • .github/workflows/next_steps_zenodo.yml
  • .github/workflows/next_steps_zenodo_issue.md

Check if there are mentions of zenodo or doi in any file of the generated package.

Test 2:

  • Push the generated package to a GitHub repository
  • Check if next_steps_zenodo.yml workflow runs
  • Check if next_steps_zenodo.yml workflow is removed after run
  • Check if a GitHub issue about zenodo is created

lyashevska marked this pull request as ready for review August 22, 2024 08:57
lyashevska requested a review from fdiblen August 22, 2024 08:57

fdiblen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice work, @lyashevska! I left a few minor comments.

Comment thread CHANGELOG.md Outdated
Comment thread copier.yml Outdated
Comment thread profiles.md Outdated
Comment thread template/README.md.jinja Outdated
Comment thread template/README.dev.md.jinja Outdated
lyashevska and others added 5 commits August 22, 2024 15:49
Co-authored-by: fdiblen <144492+fdiblen@users.noreply.github.com>
Co-authored-by: fdiblen <144492+fdiblen@users.noreply.github.com>
Co-authored-by: fdiblen <144492+fdiblen@users.noreply.github.com>
Co-authored-by: fdiblen <144492+fdiblen@users.noreply.github.com>

fdiblen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Almost there! You have two more small fixes ;)

Comment thread template/README.dev.md.jinja Outdated
Comment thread template/README.md.jinja Outdated
lyashevska and others added 2 commits August 22, 2024 16:33
Co-authored-by: fdiblen <144492+fdiblen@users.noreply.github.com>
Co-authored-by: fdiblen <144492+fdiblen@users.noreply.github.com>
lyashevska requested a review from fdiblen August 22, 2024 14:33

fdiblen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice! Good to merge!

lyashevska merged commit ee76bec into main Aug 22, 2024
lyashevska deleted the 469-zenodo branch August 22, 2024 14:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL