FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

535-menu and profiles by fdiblen · Pull Request #547 · NLeSC/python-template · GitHub

535-menu and profiles - #547

Merged
fdiblen merged 35 commits into
mainfrom
535_menu_and_profiles
Aug 27, 2024
Merged

535-menu and profiles#547
fdiblen merged 35 commits into
mainfrom
535_menu_and_profiles

Conversation

fdiblen commented Aug 23, 2024
edited
Loading

Copy link
Copy Markdown
Member

Checklist

Description

This PR

  • groups the questions in dedicated yaml files
  • selects the default features for the recommended profile
  • adds a submenu for GitHub Actions
  • adds a submenu for Citation
  • adds help field to questions missing this field
  • adds a default value for package version

**Known problems:

Related issues:

Instructions to review the pull request

Step-1: Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Step-2: Create a package

copier copy --vcs-ref 535_menu_and_profiles https://github.com/nlesc/python-template test_menu

Step-3: Test the features
Repeat Step-2 for each feature individually and check

  • if the expected files are created
  • expected text is present (e.g. if you select citation, related text should be present)

If you see something unexpected, add it to your review and create a GitHub issue.

fdiblen marked this pull request as ready for review August 26, 2024 13:08
fdiblen requested review from lyashevska and sjvrijn August 26, 2024 13:08

lyashevska commented Aug 26, 2024
edited
Loading

Copy link
Copy Markdown
Collaborator

Results of the testing:

  • recommended and let me choose profile have the same structure as minimum, no new features are being added when selected. This behaviour is introduced with this PR.

lyashevska left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @fdiblen. Great work. Almost there! Please check #570

lyashevska self-requested a review August 27, 2024 09:24

lyashevska left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No more comments. Looks great!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL