FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove unused isort configuration by bouweandela · Pull Request #591 · NLeSC/python-template · GitHub

/ python-template Public

Remove unused isort configuration - #591

Merged
bouweandela merged 2 commits into
mainfrom
remove-unused-isort-config
Aug 28, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Remove unused isort configuration#591
bouweandela merged 2 commits into
mainfrom
remove-unused-isort-config

Conversation

bouweandela commented Aug 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Checklist before requesting a review

  • I have read the contribution guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • All user facing changes have been added to CHANGELOG.md

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

List of related issues or pull requests**

None

Describe the changes made in this pull request

Remove unused isort configuration again since #392 seems to have gotten undone in #399.

bouweandela mentioned this pull request Aug 27, 2024
Merged
3 tasks
bouweandela marked this pull request as ready for review August 27, 2024 13:29
fdiblen self-requested a review August 28, 2024 09:06
fdiblen approved these changes Aug 28, 2024
View reviewed changes

fdiblen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch @bouweandela. Thank you!
You can merge it ;)

bouweandela merged commit 953db45 into main Aug 28, 2024
bouweandela deleted the remove-unused-isort-config branch August 28, 2024 10:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fdiblen fdiblen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL