Fix flgBaseWriter to use kParseNumbersAsStringsFlag instead of kParseFullPrecisionFlag - #241
Merged
SinghRajenM merged 4 commits intoMar 21, 2026
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve exact number text in Compress/Format operations
Problem
flgBaseWriter (used by Compress, Format, and Validate) used kParseFullPrecisionFlag, which parsed numbers as double and re-serialized them. This caused:
Fix
Aligned flgBaseWriter with flgBaseReader — both now use kParseNumbersAsStringsFlag. Numbers pass through as exact original text in all operations (compress, format, sort-by-key).
Changes
Testing
All 95 plugin tests pass. All 477 RapidJSON tests pass.