FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(onboard): exclude Hermes Portable from managed activation by ericksoa · Pull Request #9635 · NVIDIA/NemoClaw · GitHub

fix(onboard): exclude Hermes Portable from managed activation - #9635

Open
ericksoa wants to merge 1 commit into
feat/b3-e-buildless-onboarding-9140from
fix/hermes-portable-managed-activation-9634
Open

fix(onboard): exclude Hermes Portable from managed activation#9635
ericksoa wants to merge 1 commit into
feat/b3-e-buildless-onboarding-9140from
fix/hermes-portable-managed-activation-9634

Conversation

Copy link
Copy Markdown
Contributor

Summary

Stock managed-runtime activation accepted Hermes Portable because the decision input only carried the OpenClaw portable lifecycle flag. This PR carries the Hermes Portable lifecycle into that decision, preserving the shipped Hermes Dockerfile path while leaving normal shipped-agent managed activation and the fail-closed guard unchanged. The activation unit test now covers the separate Hermes Portable flag that prior coverage omitted.

Related Issue

Fixes #9634

Stacked on #9323. Supports #9140.

Changes

  • Pass the Hermes Portable lifecycle selection into the stock managed-runtime activation decision.
  • Exclude OpenClaw Portable and Hermes Portable while retaining managed activation for shipped non-Portable agents.
  • Add focused regression coverage for Hermes Portable activation selection.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

DGX Station Hardware Evidence

  • Tested on DGX Station
  • Tested commit: Not applicable
  • Station profile/scenario: Not applicable
  • Result: Not applicable
  • Supporting evidence: Not applicable

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run --project cli src/lib/onboard/managed-workload/onboard-orchestration.test.ts (8 passed); npx vitest run --project cli src/lib/onboard/sandbox-gpu-create-flow-hermes-portable.test.ts (8 passed)
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Aaron Erickson aerickson@nvidia.com

ericksoa self-assigned this Aug 19, 2026

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c40bc55e-9b79-4e69-8c18-346a8e58b904

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit bc62903 in the fix/hermes-portable-... branch remains at 96%, unchanged from commit d34dab5 in the feat/b3-e-buildless-... branch.

senthilr-nv added bug-fix PR fixes a bug or regression area: onboarding Onboarding FSM, provider setup, sandbox launch, or first-run flow area: sandbox OpenShell sandbox lifecycle, runtime, config, or recovery integration: hermes Hermes integration behavior security v0.0.112 Release target labels Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: onboarding Onboarding FSM, provider setup, sandbox launch, or first-run flow area: sandbox OpenShell sandbox lifecycle, runtime, config, or recovery bug-fix PR fixes a bug or regression integration: hermes Hermes integration behavior security v0.0.112 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL