🌿 Preview your docs: https://nvidia-preview-pr-2711.docs.buildwithfern.com/openshell

@ gator, as mentioned in the reply to your comment we will defer the docs. #2711 (comment)

Label test:e2e applied for 2dedd9c. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

gator-agent

Maintainer Review Nudge

This PR has been in gator:approval-needed for more than 48 business hours with no maintainer approval.

@NVIDIA/openshell-maintainers @NVIDIA/openshell-codeowners @mrunalp @maxamillion @derekwaynecarr, can someone review and either approve, request changes, or close this out?

gator-agent

Author Follow-Up Nudge

This PR has been in gator:in-review for more than 48 business hours with unresolved review feedback.

@johntmyers, please either update docs/reference/policy-schema.mdx and docs/sandboxes/policies.mdx for the new protocol: tcp contract, or obtain an explicit maintainer waiver for deferring those canonical docs. If the standalone docs PR is the intended resolution, please link it so maintainers can make that decision.

gator-agent

Maintainer Convergence Decision

Thanks @johntmyers. I checked the current head after your response to @pimlock's request to require a non-empty host and a valid concrete port for explicit protocol: tcp endpoints. The independent critical-only review found no newly introduced Critical defect, and the four earlier stage-1 findings remain resolved.

Head SHA: 5157062bebefdc9271432b10829964b093b950f0
Base SHA: 2eb0880a006737370616c93c4c6dbfafabc8ac88
Merge base SHA: 2eb0880a006737370616c93c4c6dbfafabc8ac88
Patch ID: 31b4660a50039e2c01ad49c0137f06200b82e4b8
Gator payload: 4

The autonomous Warning budget is exhausted, and a specific maintainer decision is required before review can proceed.

Root-cause findings:

• The requested explicit-TCP destination validation was broadened to every network endpoint. The new MissingEndpointHost check rejects the existing hostless allowed_ips mode, even though proto/sandbox.proto documents that an empty host with allowed_ips matches any hostname resolving into the allowed range and sandbox-policy.rego implements that behavior. This is a concrete public policy compatibility change outside the plan's stage-1 requirement that only explicit protocol: tcp eligibility have a non-empty host and concrete port.

Scope growth:

• The remediation changes validation semantics for all endpoint protocols and removes a currently supported endpoint shape, rather than enforcing the TCP-specific eligibility boundary requested by the series plan and @pimlock.

Reviewer-quality signals:

• The normalized critical-only review proposed no new findings; this convergence request comes from the separate mandatory scope-growth check.

Maintainer action: @pimlock or another OpenShell maintainer, please decide whether this PR should (a) limit the new host/port requirement to explicit protocol: tcp, preserving hostless allowed_ips, or (b) intentionally retire the hostless mode here and require the corresponding public-contract, compatibility, and migration treatment. A maintainer confirmation of the intended boundary will unblock the next step.

Next state: gator:blocked
Blocked reason: review_convergence_decision_required

gator-agent

Blocked

Thanks @pimlock. I checked your maintainer clarification that the existing hostless non-TCP allowed_ips mode remains supported while explicit protocol: tcp requires a DNS hostname. Thanks @johntmyers. I checked current head 26d10b1de8a1915e72aae2b87ad93e8986cac16c; the shared validation now preserves that legacy mode and applies the DNS-host boundary to explicit TCP with dedicated validation coverage. That resolves the prior maintainer convergence decision.

Head SHA: 26d10b1de8a1915e72aae2b87ad93e8986cac16c
Gator payload: 4

Gator is now blocked because GitHub reports this head as unmergeable with merge conflicts (mergeable: false, mergeable_state: dirty). The required critical-only author-delta review cannot proceed against a conflicted patch.

Next action: @johntmyers, resolve the conflicts with main and push the conflict-resolved head. Gator will then rebuild the feedback ledger and review only the new author delta under the stage-1 boundary.

gator-agent

Re-check After Author Update

Thanks @johntmyers. I reviewed conflict-resolved head 808f5fbad349fadcd38ddd3772e67d0308546194 after your update. Thanks @pimlock. I also preserved your maintainer clarification that hostless non-TCP allowed_ips remains supported while explicit protocol: tcp requires a DNS hostname and at least one valid concrete port.

Validation: This remains project-valid as stage 1 of the accepted policy-DNS/transparent-TCP series. It establishes the authoritative generation-consistent authorization boundary, stable endpoint identity, explicit protocol: tcp policy contract, future transport/correlation interfaces, and the unused pinned-address connector foundation. Policy DNS, resolved-endpoint storage, kernel capture, resolver injection, native transparent TCP, and runtime enablement remain correctly deferred to later PRs.

Head SHA: 808f5fbad349fadcd38ddd3772e67d0308546194
Base SHA: 998db0478060976b3f530cdbbc26f336752b90a5
Merge base SHA: 998db0478060976b3f530cdbbc26f336752b90a5
Patch ID: ba14bc8d90b491c93759c15596f8237b08851e06
Gator payload: 4
Review mode: critical_only
Previous reviewed SHA: 22a4de473a88e7d8da23a93ed787a30afbf4ce3d
Review budget exhausted: yes
Maintainer decision required: no

What I checked: the complete authoritative series plan, the durable feedback ledger, the conflict-resolution author delta, the TCP-specific host and port validation boundary, preservation of hostless non-TCP allowed_ips, and the current-head workflow dispatch.

Blocking findings:

• No newly introduced Critical findings in the current author-only delta.

Carried findings:

• None. GATOR-c9ee490d-01 through GATOR-c9ee490d-04 remain resolved.

Docs: The canonical Fern policy pages continue to document explicit protocol: tcp, its current L4 equivalence to omitted protocol, and its rejected L7-only fields.

Checks: The merge-conflict blocker is cleared. test:e2e remains applied; DCO is green, Branch Checks is running, and Helm Lint and E2E are queued for this head.

Disposition: Review feedback is resolved and the required current-head workflows are dispatched.

Next state: gator:watch-pipeline

gator-agent

Blocked

Head SHA: 062ce26e11c2aff44b9f21d23afc7c7ac9b1c47a
Gator payload: 4

Stage-1 review is complete. The feedback ledger identifies this head as rebase-equivalent to reviewed head 808f5fbad349fadcd38ddd3772e67d0308546194; all four prior findings remain resolved. Thanks @pimlock, maintainer approval is present.

Gator is blocked by the required OpenShell / E2E gate. Run 32309575283 failed across the VM, Podman, and Kubernetes jobs during shared tool bootstrap: Go followed golangci-lint deprecation metadata to nonexistent revision v2.13.0. This is not a PR-owned stage-1 regression: mise.toml has the same golangci-lint = "2.12" pin on this head, its base, and current main, and the jobs failed before exercising the changed policy/proxy behavior.

Next action: @NVIDIA/openshell-maintainers, fix or update the shared golangci-lint tool pin on main and rebase this PR, or rerun the current-head Branch E2E workflow after the upstream revision is available. Gator will then re-check the required gate and move to gator:merge-ready if it is green with the existing approval.

gator-agent

Re-check After Author Update

Thanks @johntmyers. I reviewed current head 6b01545702a7a2da2384bf319fceb489a887eb27 after the rebase that cleared the shared E2E bootstrap blocker. I preserved @pimlock's maintainer clarification that hostless non-TCP allowed_ips remains supported while explicit protocol: tcp requires a DNS hostname and at least one valid concrete port.

Validation: This remains project-valid as stage 1 of the accepted policy-DNS/transparent-TCP series. It establishes the authoritative generation-consistent authorization boundary, stable endpoint identity, explicit protocol: tcp policy contract, future transport/correlation interfaces, and the unused pinned-address connector foundation. Policy DNS, resolved-endpoint storage, kernel capture, resolver injection, native transparent TCP, and runtime activation remain correctly deferred to later PRs.

Head SHA: 6b01545702a7a2da2384bf319fceb489a887eb27
Base SHA: 9505ca5ed1159c462296dbeaa045bfd1fc9ba53b
Merge base SHA: 9505ca5ed1159c462296dbeaa045bfd1fc9ba53b
Patch ID: 0a8e1c40ef62e028b3298e92ddbe2bf1e1e64501
Gator payload: 4
Review mode: critical_only
Previous reviewed SHA: 808f5fbad349fadcd38ddd3772e67d0308546194
Review budget exhausted: yes
Maintainer decision required: no

What I checked: the complete authoritative series plan, the durable feedback ledger, the author-only range comparison across the rebase, the Podman stop/restart fence conflict resolution, preservation of the stage-1 TCP host/port validation boundary, and current-head workflow dispatch.

Blocking findings:

• No newly introduced Critical findings in the latest author-only delta.

Carried findings:

• None. GATOR-c9ee490d-01 through GATOR-c9ee490d-04 remain resolved.

Docs: The canonical Fern policy pages continue to document explicit protocol: tcp, its current L4 equivalence to omitted protocol, and its rejected L7-only fields.

Checks: The prior shared E2E bootstrap blocker is cleared by the rebase. test:e2e remains applied; DCO and Helm Lint are green, while current-head Branch Checks and E2E are queued.

Disposition: Review feedback is resolved and the required current-head workflows are dispatched.

Next state: gator:watch-pipeline

gator-agent

Monitoring Complete

Monitoring is complete because this PR has merged.

Head SHA: 6b01545702a7a2da2384bf319fceb489a887eb27
Gator payload: 4

Final status: Gator reached gator:merge-ready after the stage-1 review completed, required checks passed, and maintainer approval was present.

I removed the active gator:* label because there is nothing left for gator to monitor on this PR.