FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Prerelease NVML bindings by mdboom · Pull Request #1284 · NVIDIA/cuda-python · GitHub

/ cuda-python Public

Prerelease NVML bindings - #1284

Merged
mdboom merged 18 commits into
NVIDIA:mainfrom
mdboom:nvml
Dec 9, 2025
ConversationCommits (18)ChecksFiles changed
Merged

Prerelease NVML bindings#1284
mdboom merged 18 commits into
NVIDIA:mainfrom
mdboom:nvml

Conversation

mdboom commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

No description provided.

copy-pr-bot Bot commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

leofang linked an issue Nov 24, 2025 that may be closed by this pull request
Add nvml bindings #863
Closed
1 task
leofang added P0 High priority - Must do! feature New feature or request cuda.bindings Everything related to the cuda.bindings module labels Nov 24, 2025

mdboom commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

This comment has been minimized.

Sign in to view

mdboom commented Nov 24, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

rwgk mentioned this pull request Nov 26, 2025
Closed

mdboom commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

mdboom commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

mdboom commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

mdboom commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

leofang commented Dec 1, 2025

Copy link
Copy Markdown
Member

Let's get #1244 merged first to reduce the diff (from cufile).

mdboom commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

Let's get #1244 merged first to reduce the diff (from cufile).

Yes, if we want to merge #1244 before 13.1 (I'm not sure that we do).

mdboom commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

mdboom commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

mdboom commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

mdboom commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

mdboom marked this pull request as ready for review December 3, 2025 16:02

copy-pr-bot Bot commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

kkraus14 previously requested changes Dec 3, 2025
View reviewed changes

kkraus14 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Requesting changes purely to prevent merging shortly before release 😄

mdboom commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

kkraus14 dismissed their stale review December 8, 2025 16:20

Release is out :)

mdboom commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

rwgk reviewed Dec 8, 2025
View reviewed changes

rwgk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just a couple basic things that stood out to me while glancing through.

Comment thread cuda_bindings/tests/nvml/test_pynvml.py
Comment thread cuda_bindings/tests/nvml/conftest.py Outdated
Comment thread cuda_bindings/tests/nvml/conftest.py Outdated
kkraus14 approved these changes Dec 9, 2025
View reviewed changes

kkraus14 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM other than @rwgk's comments 😄

mdboom commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

mdboom enabled auto-merge (squash) December 9, 2025 14:01
mdboom merged commit df394be into NVIDIA:main Dec 9, 2025
80 checks passed

github-actions Bot commented Dec 9, 2025

Copy link
Copy Markdown
Doc Preview CI
Preview removed because the pull request was closed or merged.

mdboom deleted the nvml branch December 9, 2025 16:12

leofang commented Jan 14, 2026

Copy link
Copy Markdown
Member

Backported in #1349.

leofang added this to the cuda-python 13.1.0 & 12.9.5 milestone Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

rwgk rwgk left review comments
leofang leofang left review comments
kkraus14 kkraus14 approved these changes

Assignees

mdboom

Labels

cuda.bindings Everything related to the cuda.bindings module feature New feature or request P0 High priority - Must do!

Projects

None yet

Milestone

cuda-python 13.1.0 & 12.9.5

Development

Successfully merging this pull request may close these issues.

Add nvml bindings

4 participants

Back | FazBrowse Home | New Git URL