Skip a UVM-Heavy Test Under Compute Sanitizer - #1400
Merged
leofang merged 1 commit intoDec 18, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Andy-Jost
marked this pull request as draft
December 17, 2025 20:02
Copy link
Copy Markdown
Contributor
Author
|
/ok to test ec93c1249ec517b2c42648d9c03db0959a2eb2a9 |
Sorry, something went wrong.
This comment has been minimized.
Andy-Jost
force-pushed
the
disable-tests-for-release
branch
2 times, most recently
from
ce6b1b5 to
e3183ab
Compare
December 17, 2025 21:58
Copy link
Copy Markdown
Contributor
Author
|
/ok to test e3183abb9dc0403ac63e9d868178c50b1ef8cfd8 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
/ok to test cb86bd13917a38ad4b0cd3d0801644a9fd712fab |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
/ok to test 8823fccecc33aa5c1517a8f19afba18ff0eef6e3 |
Sorry, something went wrong.
- Add --durations=0 to CI pytest invocations to report per-test timings. - Add cuda_python_test_helpers.under_compute_sanitizer() and use it to skip the UVM-heavy PatternGen seed test under compute-sanitizer.
Andy-Jost
force-pushed
the
disable-tests-for-release
branch
from
8823fcc to
cbe5b2d
Compare
December 17, 2025 23:42
Andy-Jost
commented
Dec 17, 2025
Comment thread
ci/tools/run-tests
| @@ -32,7 +32,7 @@ if [[ "${test_module}" == "pathfinder" ]]; then | |||
| echo "Running pathfinder tests with " \ | |||
| "LD:${CUDA_PATHFINDER_TEST_LOAD_NVIDIA_DYNAMIC_LIB_STRICTNESS} " \ | |||
| "FH:${CUDA_PATHFINDER_TEST_FIND_NVIDIA_HEADERS_STRICTNESS}" | |||
| pytest -ra -s -v tests/ |& tee /tmp/pathfinder_test_log.txt | |||
| pytest -ra -s -v --durations=0 tests/ |& tee /tmp/pathfinder_test_log.txt | |||
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
It seems reasonable to report test times so that these issues are easier to debug in the future.
Sorry, something went wrong.
Andy-Jost
marked this pull request as ready for review
December 17, 2025 23:46
Copy link
Copy Markdown
Contributor
Author
|
CI confirms the fix. This test was taking >20min: CI / Test linux-64 / py3.12, 12.9.1, local, l4 (push)Successful in 6m |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Longest durations now reported in the test logs: ============================== slowest durations =============================== 7.42s call tests/memory_ipc/test_workerpool.py::TestIpcWorkerPool::test_main[3] 6.67s call tests/memory_ipc/test_workerpool.py::TestIpcWorkerPoolUsingRegistry::test_main[3] 6.64s call tests/memory_ipc/test_workerpool.py::TestIpcWorkerPoolUsingIPCDescriptors::test_main[3] 6.63s call tests/memory_ipc/test_workerpool.py::TestIpcWorkerPoolUsingRegistry::test_main[1] 6.44s call tests/memory_ipc/test_send_buffers.py::TestIpcReexport::test_main[DeviceMR] 6.38s call tests/memory_ipc/test_workerpool.py::TestIpcWorkerPool::test_main[1] 5.60s call tests/memory_ipc/test_memory_ipc.py::TestIPCSharedAllocationHandleAndBufferObjects::test_main[DeviceMR] 5.57s call tests/memory_ipc/test_memory_ipc.py::TestIPCSharedAllocationHandleAndBufferDescriptors::test_main[DeviceMR] 4.50s call tests/memory_ipc/test_memory_ipc.py::TestIPCMempoolMultiple::test_main[DeviceMR] 4.43s call tests/memory_ipc/test_send_buffers.py::TestIpcSendBuffers::test_main[1] 4.40s call tests/memory_ipc/test_workerpool.py::TestIpcWorkerPoolUsingIPCDescriptors::test_main[1] 4.39s call tests/memory_ipc/test_serialize.py::TestObjectSerializationDirect::test_main[DeviceMR] 3.42s call tests/memory_ipc/test_event_ipc.py::TestEventIpc::test_main[DeviceMR] 3.36s call tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[False-True-True] 3.36s call tests/memory_ipc/test_errors.py::TestImportWrongMR::test_main[DeviceMR] 3.36s call tests/memory_ipc/test_send_buffers.py::TestIpcSendBuffers::test_main[3] 3.35s call tests/memory_ipc/test_errors.py::TestDanglingBuffer::test_main[DeviceMR] 3.35s call tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[False-False-True] 3.35s call tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[False-True-False] 3.35s call tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[True-False-True] 3.35s call tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[True-True-False] 3.35s call tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[False-False-False] 3.34s call tests/memory_ipc/test_serialize.py::TestObjectSerializationWithMR::test_main[DeviceMR] 3.34s call tests/memory_ipc/test_serialize.py::TestObjectPassing::test_main[DeviceMR] 3.33s call tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[True-False-False] 3.32s call tests/memory_ipc/test_event_ipc.py::TestIpcEventProperties::test_main[True-True-True] 3.32s call tests/memory_ipc/test_memory_ipc.py::TestIpcMempool::test_main[DeviceMR] 3.31s call tests/memory_ipc/test_errors.py::TestImportBuffer::test_main[DeviceMR] 2.65s call tests/memory_ipc/test_errors.py::TestAllocFromImportedMr::test_main[DeviceMR] 2.39s call tests/example_tests/test_basic_examples.py::TestExamples::test_example[/__w/cuda-python/cuda-python/cuda_core/tests/example_tests/../../examples/vector_add.py] 2.35s call tests/example_tests/test_basic_examples.py::TestExamples::test_example[/__w/cuda-python/cuda-python/cuda_core/tests/example_tests/../../examples/saxpy.py] 2.25s call tests/example_tests/test_basic_examples.py::TestExamples::test_example[/__w/cuda-python/cuda-python/cuda_core/tests/example_tests/../../examples/memory_ops.py] 1.65s call tests/test_helpers.py::test_latchkernel |
Sorry, something went wrong.
leofang
approved these changes
Dec 18, 2025
leofang
enabled auto-merge (squash)
December 18, 2025 00:11
Copy link
Copy Markdown
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjust CI to improve debuggability of long-running tests.
Changes
Rationale
test_patterngen_seeds performs many syncs and host/device-visible memory comparisons; under compute-sanitizer this can balloon to very long runtimes in some CI environments. Skipping it under sanitizer keeps the CI signal while avoiding hour-scale jobs.
Test plan