FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(self-managed): update the cassandra chart pin and naming by along-2017 · Pull Request #1024 · NVIDIA/nvcf · GitHub

/ nvcf Public

fix(self-managed): update the cassandra chart pin and naming - #1024

Merged
mikeyrcamp merged 3 commits into
mainfrom
fix/self-managed/update-cassandra-chart-0.20.1
Aug 20, 2026
ConversationCommits (3)ChecksFiles changed
Merged

fix(self-managed): update the cassandra chart pin and naming#1024
mikeyrcamp merged 3 commits into
mainfrom
fix/self-managed/update-cassandra-chart-0.20.1

Conversation

along-2017 commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why

Chart helm-nvcf-cassandra 0.20.1 was published with the corrected image
defaults (cassandra 5.0.8-nv-2.0.1; the previous default tag was never
published under the Apache image name). The self-managed stack still
pins 0.19.1 and still points the image at the retired
"bitnami-cassandra" repository, so cassandra installs from main cannot
pull the image.

What changed

  • deploy/stacks/self-managed/helmfile.d/01-dependencies.yaml.gotmpl:
    cassandra release chart version 0.19.1 to 0.20.1.
  • deploy/stacks/self-managed/global.yaml.gotmpl: point the cassandra
    image at the renamed "cassandra" repository and add a tag knob
    following the migrations pattern; drop the dynamicSeedDiscovery image
    block, which the chart has no key for (dead Bitnami-era values).

Customer Release Notes

Self-hosted: cassandra installs pull the published Apache-based image
by default; environments can still override the tag.

Plan Summary

Cassandra release in the self-managed stack: chart 0.19.1 to 0.20.1,
image repository "bitnami-cassandra" to "cassandra". Image defaults
move to cassandra 5.0.8-nv-2.0.1 and migrations 0.16.0.

Usage

Not applicable

Testing

  • Full self-managed stack render with a local environment succeeds and
    emits the renamed image at the published tag for both the cassandra
    container and the cassandra-conf-init initContainer.
  • Standalone render of chart 0.20.1 with the CI values confirms the
    chart defaults alone resolve the same tag.
  • Stack wiring tests (make -C deploy/stacks/self-managed test) pass.
  • tests/bdd short suite passes (it asserts on global.yaml.gotmpl).
  • The migrations 0.16.0 image is published.

Notes

Overlaps with the CLI install-path PR, which carries the same
global.yaml.gotmpl rename for the BDD suite: after this merges, that
branch needs a rebase that drops its duplicate hunk, and the
cassandra.image.tag pins in its BDD fixtures become redundant.

References

Relates to #1019

Summary by CodeRabbit

  • Chores
    • Updated the Cassandra deployment component to a newer chart version.
    • Updated Cassandra image configuration to use the standard Cassandra image repository.
    • Added support for optionally specifying a Cassandra image tag for more flexible deployment control.

fix(self-managed): update the cassandra chart pin to 0.20.1
02b46d5 
Chart 0.20.1 carries the corrected image defaults: the Apache-based
cassandra build 5.0.8-nv-2.0.1 (the previous default tag was never
published) and migrations 0.16.0. Consume it in the self-managed
stack.

The stack must also point the cassandra image at the renamed
"cassandra" repository for the new default to resolve; that rename
is in review separately.

Signed-off-by: along <along@nvidia.com>
along-2017 requested a review from a team as a code owner August 20, 2026 00:47
along-2017 requested a review from rohithb-hub August 20, 2026 00:47

coderabbitai Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2e73e308-ab3c-4e91-b141-1a6fe386e441

📥 Commits

Reviewing files that changed from the base of the PR and between 02b46d5 and ecc411f.

📒 Files selected for processing (1)
  • deploy/stacks/self-managed/global.yaml.gotmpl

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

📝 Walkthrough

Walkthrough

The self-managed deployment updates the Cassandra chart to 0.20.1. It also changes the initialization image repository to cassandra and supports an optional configured image tag.

Changes

Cassandra deployment update

Layer / File(s) Summary
Update Cassandra chart version
deploy/stacks/self-managed/helmfile.d/01-dependencies.yaml.gotmpl		 The Cassandra release now uses chart version 0.20.1.
Update Cassandra image configuration
deploy/stacks/self-managed/global.yaml.gotmpl		 The Cassandra initialization image uses the cassandra repository and conditionally applies cassandra.image.tag.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ecc41

The PR updates the self-managed Cassandra chart and image defaults so installs use the published Apache-based image while preserving tag overrides; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

  • NVIDIA/nvcf#934: Updates related self-managed Cassandra chart and image configuration.
  • NVIDIA/nvcf#1015: Updates the Cassandra image repository and configurable image tag.

Suggested reviewers: rohithb-hub, sparve-nv

🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows Conventional Commits format and accurately describes the Cassandra chart pin and naming updates.
✨ Finishing Touches 🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/self-managed/update-cassandra-chart-0.20.1

Comment @coderabbitai help to get the list of available commands.

fix(self-managed): point the cassandra image at the renamed repository
577b042 
The Apache-based chart publishes its image as "cassandra"; the
retired "bitnami-cassandra" repository has no 5.0.8 builds. Add a
tag knob following the migrations pattern so environments can
override the chart default.

Drop the dynamicSeedDiscovery image block: the chart has no such
key, so the values were dead.

Signed-off-by: along <along@nvidia.com>
fix: trim the comments
ecc411f
along-2017 requested a review from nvjmcnamee August 20, 2026 01:08
along-2017 changed the title fix(self-managed): update the cassandra chart pin to 0.20.1 fix(self-managed): update the cassandra chart pin and naming Aug 20, 2026
mikeyrcamp added this pull request to the merge queue Aug 20, 2026
Merged via the queue into main with commit 178e2a3 Aug 20, 2026
18 checks passed
mikeyrcamp deleted the fix/self-managed/update-cassandra-chart-0.20.1 branch August 20, 2026 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sbaum1994 sbaum1994 approved these changes
rohithb-hub Awaiting requested review from rohithb-hub rohithb-hub is a code owner automatically assigned from NVIDIA/nvcf-dev
nvjmcnamee Awaiting requested review from nvjmcnamee

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL