The framerate of ArgusMonoNode was hardcoded to 30 fps in argus_camera_mono_node.yaml and likewise with argus_camera_stereo_node.yaml. If I need to change into a sensor mode with 60 FPS, instead of modifying those files in the repo's config folder, it is convenient to expose that as a ROS parameter as done with mode_ and others.
I have tested this with dual IMX676s, putting them into mode 2 (1776x1778 @ 60 FPS). With this parameter unlocked and set to 60 FPS in my launch file, I can now subscribe to downstream NitrosImages at full 60 FPS, and if I reduce the parameter setting it also reduces the framerate accordingly.
Would love to see this added in the next isaac_ros release!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The framerate of ArgusMonoNode was hardcoded to 30 fps in argus_camera_mono_node.yaml and likewise with argus_camera_stereo_node.yaml. If I need to change into a sensor mode with 60 FPS, instead of modifying those files in the repo's config folder, it is convenient to expose that as a ROS parameter as done with mode_ and others.
I have tested this with dual IMX676s, putting them into mode 2 (1776x1778 @ 60 FPS). With this parameter unlocked and set to 60 FPS in my launch file, I can now subscribe to downstream NitrosImages at full 60 FPS, and if I reduce the parameter setting it also reduces the framerate accordingly.
Would love to see this added in the next isaac_ros release!
Example usage in launch file:
left_argus_mono_node = ComposableNode( name='argus_mono_left', package='isaac_ros_argus_camera', plugin='nvidia::isaac_ros::argus::ArgusMonoNode', parameters=[{ 'camera_id':0, 'mode':2, 'framerate':60, 'use_hw_timestamp':True, 'camera_info_url':'file:///workspaces/isaac_ros-dev/calib.yaml' }], )