feat(ActionBar): apply text color when largeTitletextAttribute is set… · NativeScript/NativeScript@b58dff0 · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 773
• Pull requests 69
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit b58dff0

Browse filesBrowse the repository at this point in the historyBrowse files

NickIliev

authored and

dtopuzov

committed

feat(ActionBar): apply text color when largeTitletextAttribute is set on iOS (#6631)

* apply CSS text color when largeTitletextAttribute is set on iOS * common logic improvment

1 parent 65e3a19 commit b58dff0
Copy full SHA for b58dff0

1 file changed

+10-10Lines changed: 10 additions & 10 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/action-bar
  • action-bar.ios.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/action-bar/action-bar.ios.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/action-bar/action-bar.ios.ts

+10-10Lines changed: 10 additions & 10 deletions

Original file line number	Diff line number	Diff line change
@@ -258,16 +258,22 @@ export class ActionBar extends ActionBarBase {
258	258
259	259	private updateColors(navBar: UINavigationBar) {
260	260	const color = this.color;
	261	+ this.setColor(navBar, color);
	262	+
	263	+ const bgColor = <Color>this.backgroundColor;
	264	+ navBar.barTintColor = bgColor ? bgColor.ios : null;
	265	+ }
	266	+
	267	+ private setColor(navBar: UINavigationBar, color?: Color) {
261	268	if (color) {
262	269	navBar.titleTextAttributes = <any>{ [NSForegroundColorAttributeName]: color.ios };
	270	+ navBar.largeTitleTextAttributes = <any>{ [NSForegroundColorAttributeName]: color.ios };
263	271	navBar.tintColor = color.ios;
264	272	} else {
265	273	navBar.titleTextAttributes = null;
	274	+ navBar.largeTitleTextAttributes = null;
266	275	navBar.tintColor = null;
267	276	}
268		-
269		- const bgColor = <Color>this.backgroundColor;
270		- navBar.barTintColor = bgColor ? bgColor.ios : null;
271	277	}
272	278
273	279	public _onTitlePropertyChanged() {
@@ -359,13 +365,7 @@ export class ActionBar extends ActionBarBase {
359	365	}
360	366	[colorProperty.setNative](color: Color) {
361	367	const navBar = this.navBar;
362		- if (color) {
363		- navBar.tintColor = color.ios;
364		- navBar.titleTextAttributes = <any>{ [NSForegroundColorAttributeName]: color.ios };
365		- } else {
366		- navBar.tintColor = null;
367		- navBar.titleTextAttributes = null;
368		- }
	368	+ this.setColor(navBar, color);
369	369	}
370	370
371	371	[backgroundColorProperty.getDefault](): UIColor {

0 commit comments

Comments

0 (0)