FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(ActionBar): apply text color when largeTitletextAttribute is set on iOS by NickIliev · Pull Request #6631 · NativeScript/NativeScript · GitHub

feat(ActionBar): apply text color when largeTitletextAttribute is set on iOS - #6631

Merged
dtopuzov merged 3 commits into
masterfrom
niliev/ios-ab-titles
Nov 30, 2018
Merged

dtopuzov merged 3 commits into
masterfrom
niliev/ios-ab-titles

Conversation

Copy link
Copy Markdown
Contributor

Related to #6621

Covers cases where large titles attribute is used on iOS

actionBar.ios.prefersLargeTitles = true;

As a result, the color set via CSS or color property will be applied for this specific attribute/

ghost assigned NickIliev Nov 27, 2018
ghost added the in progress label Nov 27, 2018
NickIliev changed the title apply CSS text color when largeTitletextAttribute is set on iOS feat(ActionBar): apply CSS text color when largeTitletextAttribute is set on iOS Nov 27, 2018
NickIliev changed the title feat(ActionBar): apply CSS text color when largeTitletextAttribute is set on iOS feat(ActionBar): apply text color when largeTitletextAttribute is set on iOS Nov 27, 2018

vakrilov left a comment
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There is another place with the same logic here.
Suggestion: extract the change in a method and use it in both places.

dtopuzov merged commit b58dff0 into master Nov 30, 2018
ghost removed the in progress label Nov 30, 2018
manoldonev deleted the niliev/ios-ab-titles branch March 22, 2019 09:38

Copy link
Copy Markdown

Would it be possible to add this for font weight as well?

lock Bot commented May 5, 2020

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL