fix(ios-action-bar): enable NavigationButton text change on first nav… · NativeScript/NativeScript@b878143 · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 773
• Pull requests 69
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit b878143

Browse filesBrowse the repository at this point in the historyBrowse files

ADjenkov

authored

fix(ios-action-bar): enable NavigationButton text change on first navigation (#5458)

1 parent a94ec99 commit b878143
Copy full SHA for b878143

1 file changed

+9Lines changed: 9 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/frame
  • frame.ios.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/frame/frame.ios.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/frame/frame.ios.ts

+9Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -13,6 +13,8 @@ import * as utils from "../../utils/utils";
13	13
14	14	export * from "./frame-common";
15	15
	16	+ const majorVersion = utils.ios.MajorVersion;
	17	+
16	18	const ENTRY = "_entry";
17	19	const NAV_DEPTH = "_navDepth";
18	20	const TRANSITION = "_transition";
@@ -88,6 +90,13 @@ export class Frame extends FrameBase {
88	90	backstackEntry[NAV_DEPTH] = navDepth;
89	91	viewController[ENTRY] = backstackEntry;
90	92
	93	+ if (!animated && majorVersion > 10) {
	94	+ // Reset back button title before pushing view controller to prevent
	95	+ // displaying default 'back' title (when NavigaitonButton custom title is set).
	96	+ let barButtonItem = UIBarButtonItem.alloc().initWithTitleStyleTargetAction("", UIBarButtonItemStyle.Plain, null, null);
	97	+ viewController.navigationItem.backBarButtonItem = barButtonItem;
	98	+ }
	99	+
91	100	// First navigation.
92	101	if (!this._currentEntry) {
93	102	// Update action-bar with disabled animations before the initial navigation.

0 commit comments

Comments

0 (0)