FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ios-action-bar): NavigationButton text change on first navigation by ADjenkov · Pull Request #5458 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(ios-action-bar): NavigationButton text change on first navigation - #5458

Merged
ADjenkov merged 1 commit into
masterfrom
djenkov/ios-back-button-text
Feb 28, 2018
ConversationCommits (1)ChecksFiles changed
Merged

fix(ios-action-bar): NavigationButton text change on first navigation#5458
ADjenkov merged 1 commit into
masterfrom
djenkov/ios-back-button-text

Conversation

ADjenkov commented Feb 23, 2018

Copy link
Copy Markdown
Contributor

The problem: NavigationButton (a.k.a back button) won't change its title on first navigation when there
is no transition animation - iOS 11+ only.

The solution: Set empty back button title on the parent view controller when navigating

For reference: stackoverflow1 and stackoverflow2

Fix #5169

ADjenkov added this to the 4.0 milestone Feb 23, 2018
ADjenkov self-assigned this Feb 23, 2018
vakrilov approved these changes Feb 23, 2018
View reviewed changes
Comment thread tns-core-modules/ui/frame/frame.ios.ts Outdated
backstackEntry[NAV_DEPTH] = navDepth;
viewController[ENTRY] = backstackEntry;

if (majorVersion > 10) {

vakrilov Feb 23, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you pls add a comment in the code explaining why this is necessary, as the fix is not obvious :)

ADjenkov force-pushed the djenkov/ios-back-button-text branch 2 times, most recently from 59e4651 to 14ce89f Compare February 23, 2018 14:54

hshristov commented Feb 23, 2018

Copy link
Copy Markdown
Contributor

@ADjenkov Won't this remove all back buttons?

manoldonev reviewed Feb 27, 2018
View reviewed changes
Comment thread tns-core-modules/ui/frame/frame.ios.ts Outdated
backstackEntry[NAV_DEPTH] = navDepth;
viewController[ENTRY] = backstackEntry;

if (majorVersion > 10) {

manoldonev Feb 27, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe extend condition to if (!animated && majorVersion > 10) ?

ADjenkov force-pushed the djenkov/ios-back-button-text branch from 14ce89f to ee60214 Compare February 27, 2018 12:35

SvetoslavTsenov commented Feb 28, 2018

Copy link
Copy Markdown
Contributor

test

ADjenkov merged commit b878143 into master Feb 28, 2018
ADjenkov deleted the djenkov/ios-back-button-text branch February 28, 2018 13:36
ghost removed bug in progress labels Feb 28, 2018

lock Bot commented Aug 26, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock Bot locked and limited conversation to collaborators Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
manoldonev manoldonev approved these changes
MartoYankov MartoYankov approved these changes
vakrilov vakrilov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

ADjenkov

Labels

None yet

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

iOS: NavigationButton text

6 participants

Back | FazBrowse Home | New Git URL