Navigation Transition Issue
Using {N} 1.6.1 for Android, setting the navigation transition using transitionAndroid has no effect.
frame.topmost().navigate({
moduleName: "next",
transitionAndroid: {name: "slide"}, // Not working
});
However, using transition works,
frame.topmost().navigate({
moduleName: "next",
transition: {name: "slide"}, // this works!
});
Root Cause
ui/frame/frame-common.ts
Looks like it's a copy & paste error...
public _getNavigationTransition(entry: definition.NavigationEntry): definition.NavigationTransition {
if (entry) {
if (platform.device.os === platform.platformNames.ios && isDefined(entry.transitioniOS)) {
return entry.transitioniOS;
}
if (platform.device.os === platform.platformNames.android && isDefined(entry.transitionAndroid)) {
return entry.transitioniOS; // <-- SHOULE BE entry.transitionAndroid
}
if (entry && isDefined(entry.transition)) {
return entry.transition;
}
}
if (isDefined(this.transition)) {
return this.transition;
}
return Frame.defaultTransition;
}
Reactions are currently unavailable
Navigation Transition Issue
Using {N} 1.6.1 for Android, setting the navigation transition using transitionAndroid has no effect.
frame.topmost().navigate({ moduleName: "next", transitionAndroid: {name: "slide"}, // Not working });However, using transition works,
frame.topmost().navigate({ moduleName: "next", transition: {name: "slide"}, // this works! });Root Cause
ui/frame/frame-common.ts
Looks like it's a copy & paste error...
public _getNavigationTransition(entry: definition.NavigationEntry): definition.NavigationTransition { if (entry) { if (platform.device.os === platform.platformNames.ios && isDefined(entry.transitioniOS)) { return entry.transitioniOS; } if (platform.device.os === platform.platformNames.android && isDefined(entry.transitionAndroid)) { return entry.transitioniOS; // <-- SHOULE BE entry.transitionAndroid } if (entry && isDefined(entry.transition)) { return entry.transition; } } if (isDefined(this.transition)) { return this.transition; } return Frame.defaultTransition; }