fix: set default values to time widgets - #4383
Merged
sis0k0 merged 7 commits intoAug 3, 2017
Merged
sis0k0 merged 7 commits into
sis0k0 merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sis0k0
force-pushed
the
vlaeva/time-properties-default-values
branch
from
09c553f to
1a7fa65
Compare
June 14, 2017 15:22
hshristov
reviewed
Jun 15, 2017
Comment thread
tests/app/ui/date-picker/date-picker-tests.ts
Outdated
| import * as datePickerModule from "tns-core-modules/ui/date-picker"; | ||
| // << date-picker-require | ||
|
|
||
| const currentDateFactory = () => new Date(); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Why not directly const currentDate = new Date(); instead of factory?
Sorry, something went wrong.
Comment thread
tns-core-modules/ui/date-picker/date-picker-common.ts
Outdated
|
|
||
| export * from "../core/view"; | ||
|
|
||
| const defaultDateFactory = () => new Date(); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Why not directly const currentDate = new Date(); instead of factory?
Sorry, something went wrong.
sis0k0
force-pushed
the
vlaeva/time-properties-default-values
branch
from
154c601 to
5c6a017
Compare
August 3, 2017 12:51
hshristov
approved these changes
Aug 3, 2017
Copy link
Copy Markdown
Contributor
Author
|
uitests |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
👍 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.