fix(android-connectivity): Add ethernet connection type - #5670
Merged
manoldonev merged 4 commits intoApr 19, 2018
Merged
manoldonev merged 4 commits into
manoldonev merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Add "ethernet" connection type to getConnectionType to correctly return a connection type when the type is "ethernet"
Copy link
Copy Markdown
|
Can one of the admins verify this patch? |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
|
Can one of the admins verify this patch? |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Can one of the admins verify this patch? |
Sorry, something went wrong.
manoldonev
approved these changes
Apr 13, 2018
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling getConnectionType on an emulator, the connection type can be returned as "ethernet", which causes getConnectionType to return none when there is a connection.
PR Checklist
2 failed on emulator un-releated to the connectivity code being changed here
To the extent to match the existing connectivity test
What is the current behavior?
If the connection type is "ethernet" getConnectionType will return none.
What is the new behavior?
If the connection type is "ethernet" getConnectionType will properly return the "ethernet" connection type
Fixes/Implements/Closes #5669.