feat(modals): Enable modal dialog chaining in IOS - #6637
Merged
dtopuzov merged 4 commits intoNov 30, 2018
Merged
dtopuzov merged 4 commits into
dtopuzov merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
MartoYankov
approved these changes
Nov 29, 2018
dtopuzov
added a commit
to NativeScript/functional-tests
that referenced
this pull request
Nov 30, 2018
Copy link
Copy Markdown
|
This bug (#5744) is occurring for me in tns 5.3.3, nativescript-angular 6.2. Upon calling (<ModalDialogParams>this.params).closeCallback(), the return promise is resolved too soon such that a subsequent modal popup fails with the same error as #5744:
|
Sorry, something went wrong.
Merged
5 tasks
Copy link
Copy Markdown
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewerAssignees
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
The closeCallback for modals in IOS is fired before the dialog is closed. If you try to open another dialog in the callback - it fails because the previous dialog is still showing.
What is the new behavior?
The closeCallback is fired after the dialog is closed - in the completion callback of dismissViewControllerAnimatedCompletion.
e2e test needed: There is a Login (second modal in cb) button in the modal-view page in the ui-tests-app. It will open a modal and on its closeCallback it will open a second one.
Fixes #5744
This PR is followup of #6370