feat: add CSS classes to app/modal root views to target platform/device/orientation/type - #7606
Merged
vchimev merged 6 commits intoAug 19, 2019
Merged
vchimev merged 6 commits into
vchimev merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
manoldonev
reviewed
Aug 1, 2019
Comment thread
tests/app/ui/styling/root-views-css-classes-tests.ts
Outdated
manoldonev
reviewed
Aug 1, 2019
Comment thread
tests/app/ui/styling/root-views-css-classes-tests.ts
Outdated
manoldonev
reviewed
Aug 1, 2019
Comment thread
tests/app/ui/styling/root-views-css-classes-tests.ts
Outdated
manoldonev
reviewed
Aug 1, 2019
Comment thread
tns-core-modules/application/application-common.ts
Outdated
manoldonev
reviewed
Aug 1, 2019
Comment thread
tns-core-modules/application/application-common.ts
Outdated
manoldonev
reviewed
Aug 1, 2019
Comment thread
tns-core-modules/application/application-common.ts
Outdated
manoldonev
reviewed
Aug 1, 2019
Comment thread
tns-core-modules/application/application.d.ts
Outdated
MartoYankov
reviewed
Aug 6, 2019
Comment thread
tests/app/ui/styling/root-views-css-classes-tests.ts
Outdated
MartoYankov
reviewed
Aug 6, 2019
Comment thread
tns-core-modules/application/application.ios.ts
Outdated
MartoYankov
reviewed
Aug 6, 2019
Comment thread
tns-core-modules/platform/platform.ios.ts
Outdated
vchimev
force-pushed
the
vchimev/root-views-css-classes
branch
3 times, most recently
from
62e4707 to
f6cba6d
Compare
August 18, 2019 11:45
Add CSS classes to app/modal root views to target platform/device/orientation/type.
vchimev
force-pushed
the
vchimev/root-views-css-classes
branch
from
b7b8a0d to
3a2d062
Compare
August 18, 2019 14:26
manoldonev
reviewed
Aug 19, 2019
Comment thread
tns-core-modules/ui/core/view/view.android.ts
manoldonev
approved these changes
Aug 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the new behavior?
Add a CSS class to the application/modal root view as follows:
application root view
modal root view
Depends on #7602.
Implements #7313.