FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ios-modal): closeCallback not being called with popover presentation style by VladimirAmiorkov · Pull Request #7189 · NativeScript/NativeScript · GitHub

fix(ios-modal): closeCallback not being called with popover presentation style - #7189

Merged
VladimirAmiorkov merged 3 commits into
releasefrom
amiorkov/popover-closed-callback-fix
May 7, 2019
Merged

VladimirAmiorkov merged 3 commits into
releasefrom
amiorkov/popover-closed-callback-fix

Conversation

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].
Fixes #7050

Developer notes

This PR introduces a new event popoverClosed to the View class. This event is raised when a modal using the presentationStyle: UIModalPresentationStyle.Popover is closed by tapping outside of the popup area.

VladimirAmiorkov self-assigned this Apr 30, 2019
cla-bot Bot added the cla: yes label Apr 30, 2019
ghost added in progress and removed cla: yes labels Apr 30, 2019
VladimirAmiorkov changed the title fix: add delegate implementation for popoverPresentationController … fix(ios-modal): closeCallback not being called with popover presentation style Apr 30, 2019
cla-bot Bot added the cla: yes label Apr 30, 2019
…and handle calling modal’s `closeCallback` #7050

chore: add example that shows "popover" mode for modal views
VladimirAmiorkov force-pushed the amiorkov/popover-closed-callback-fix branch from 3c9fffa to 70bca87 Compare May 2, 2019 12:52

Copy link
Copy Markdown
Contributor

test package_version#latest

VladimirAmiorkov merged commit aa44eb9 into release May 7, 2019
ghost removed the in progress label May 7, 2019
VladimirAmiorkov deleted the amiorkov/popover-closed-callback-fix branch May 7, 2019 14:09

mudlabs commented Jul 28, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Documentation?

The modal view docs say "By design on iPhone, a modal view appears only in fullscreen". And when I try to implement popover (or any other), that's the behaviour I get.

VladimirAmiorkov commented Jul 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@mudlabs ,

In our tests when using the presentationStyle: UIModalPresentationStyle.Popover on iOS when you deploy on iPhone it is not used as this is the behavior that is enforced by the platform itself. Taken from the iOS documentation:

In a horizontally regular environment, this style displays the view controller in a popover view. The background content is dimmed and taps outside the popover cause the popover to be dismissed. If you do not want taps to dismiss the popover, you can assign one or more views to the passthroughViews property of the associated UIPopoverPresentationController object, which you can get from the popoverPresentationController property.

In a horizontally compact environment, this option behaves the same as UIModalPresentationFullScreen.

reference link

If you find issues with this I would suggest to open a new issue report and provide full details here.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL