Resolve multiple issues with modal views that use presentationStyle: UIModalPresentationStyle.Popover - #1782
Closed
VladimirAmiorkov wants to merge 2 commits into
Closed
VladimirAmiorkov wants to merge 2 commits into
VladimirAmiorkov wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This comment has been minimized.
fix(modal): resolve issue with modal promise not being resolved when using `Popover` styled modals
VladimirAmiorkov
force-pushed
the
amiorkov/modal-close-callback-fix
branch
from
a5e93ff to
511f178
Compare
April 22, 2019 07:25
Copy link
Copy Markdown
Contributor
Author
|
test branch-tns-core-modules#amiorkov/modal-close-callback-fix |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
test branch-tns-core-modules#amiorkov/modal-close-callback-fix upload_test_reports |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
After some additional refactoring to the fix of in tns-core-modules it is not longer requried to change anything in nativescript-angular. After this PR is merged the current version of nativescript-angular should work as expected. Closing PR. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires a PR in the tns-core-modules to be merged first: NativeScript/NativeScript#7050
PR Checklist
What is the current behavior?
If you open a modal that has options for presentationStyle set to UIModalPresentationStyle.Popover if you tap outside of the popup it will be closed but opening a next modal will open empty broken modal.
What is the new behavior?
If you open a modal that has options for presentationStyle set to UIModalPresentationStyle.Popover if you tap outside of the popup it will be closed correctly and opening next modal will work as expected.
Fixes/Implements/Closes #[Issue Number].