fix(observable-array): splice(...) to return correct amount of added items - #7426
Merged
manoldonev merged 2 commits intoJul 3, 2019
Merged
manoldonev merged 2 commits into
manoldonev merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Oops, my mistake, Some weird commits went with it. Let me fix it |
Sorry, something went wrong.
edusperoni
force-pushed
the
observable-array-splice
branch
from
85409ef to
0e5cb42
Compare
June 29, 2019 00:17
Copy link
Copy Markdown
Contributor
|
test |
Sorry, something went wrong.
manoldonev
approved these changes
Jul 3, 2019
manoldonev
pushed a commit
that referenced
this pull request
Jul 3, 2019
SvetoslavTsenov
pushed a commit
that referenced
this pull request
Jul 3, 2019
manoldonev
pushed a commit
that referenced
this pull request
Jul 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
ObservableArray splice does not notify the number of updated items and it can't be inferred from the passed arguments.
What is the new behavior?
ObservableArray splice adds all updated items to addedCount, using a logic of "x items removed, y items added in their place"
The amount of change in the length of the array can be always inferred by addedCount - removed.length.
This fixes a bug that would cause FormattedString.spans.splice to keep removing spans and never adding any back.
Fixes #7425.
BREAKING CHANGES:
The addedCount variable from ObservableArray's splice change event is always the amount of added items.
Migration steps:
Ideally, developers should handle the case where items are replaced by splice. The old addedCount can be obtained by
const addedCount = event.addedCount - event.removed.length