feat: expose application orientation - #7602
Merged
vchimev merged 10 commits intoAug 14, 2019
Merged
vchimev merged 10 commits into
vchimev merged 10 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
vchimev
force-pushed
the
vchimev/orientation
branch
3 times, most recently
from
e28b712 to
3e7c24a
Compare
July 29, 2019 06:40
Merged
5 tasks
manoldonev
reviewed
Aug 1, 2019
Comment thread
tns-core-modules/application/application-common.ts
Outdated
vchimev
force-pushed
the
vchimev/orientation
branch
from
0b9bd9d to
7e4ac06
Compare
August 12, 2019 16:48
MartoYankov
reviewed
Aug 13, 2019
Comment thread
tns-core-modules/utils/utils.ios.ts
Relates to #1437.
BREAKING CHANGES: In iOS, there are concepts for device orientation (UIDeviceOrientation) and interface orientation (UIInterfaceOrientation). In here, there is no distinct implementation for both orientations. Currently, it is exposed as an `orientation` property of the device and takes into account both orientations for iOS. Deprecate `isLandscape` function as it does not work properly and it is not used internally. Migration steps: Use `device.orientation` property instead.
Move orientation from device to application. iOS: Use `UIApplication.sharedApplication.statusBarOrientation` instead of `UIDevice.currentDevice.orientation`. Implements #1437.
Also remove iOS orientation setter.
vchimev
force-pushed
the
vchimev/orientation
branch
from
7e4ac06 to
f2ab6cb
Compare
August 13, 2019 14:01
manoldonev
approved these changes
Aug 13, 2019
This was referenced Sep 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The application user interface is missing orientation property.
[iOS] UIDevice.currentDevice.orientation is in use.
What is the new behavior?
The application user interface has an orientation property.
[iOS] UIApplication.sharedApplication.statusBarOrientation is in use.
Implements #1437.