FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

DatePicker and TimePicker stylers added by enchev · Pull Request #1020 · NativeScript/NativeScript · GitHub

/ NativeScript Public

DatePicker and TimePicker stylers added #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enchev merged 3 commits into from
Nov 3, 2015
Conversation 6 Commits 3 Checks 0 Files changed
Merged

DatePicker and TimePicker stylers added #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb2fadd
DatePicker and TimePicker stylers added
Nov 2, 2015
48973e2
tests added
Nov 2, 2015
7ce26ee
stylers updated with get methods
Nov 3, 2015
File filter

Filter by extension

Filter by extension .ts  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
14 changes: 14 additions & 0 deletions apps/tests/ui/date-picker/date-picker-tests.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
import helper = require("../helper");
import viewModule = require("ui/core/view");
import datePickerTestsNative = require("./date-picker-tests-native");
import color = require("color");
import platform = require("platform");

// <snippet module="ui/date-picker" title="DatePicker">
// # DatePicker
Expand Down Expand Up @@ -51,6 +53,18 @@ export function test_DummyForCodeSnippet() {
});
}

// Supported in iOS only.
if (platform.device.os === platform.platformNames.ios) {
exports.test_set_color = function () {
helper.buildUIAndRunTest(_createDatePicker(), function (views: Array<viewModule.View>) {
var datePicker = <datePickerModule.DatePicker>views[0];
datePicker.color = new color.Color("red");
TKUnit.assertEqual(datePicker.color.ios.CGColor, datePicker.ios.valueForKey("textColor").CGColor, "datePicker.color");
});

}
}

export function test_WhenCreated_YearIsUndefined() {
helper.buildUIAndRunTest(_createDatePicker(), function (views: Array<viewModule.View>) {
var datePicker = <datePickerModule.DatePicker>views[0];
Expand Down
14 changes: 14 additions & 0 deletions apps/tests/ui/time-picker/time-picker-tests.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
import helper = require("../helper");
import viewModule = require("ui/core/view");
import timePickerTestsNative = require("./time-picker-tests-native");
import color = require("color");
import platform = require("platform");

// <snippet module="ui/time-picker" title="TimePicker">
// # TimePicker
Expand Down Expand Up @@ -44,6 +46,18 @@ export function test_DummyForCodeSnippet() {
});
}

// Supported in iOS only.
if (platform.device.os === platform.platformNames.ios) {
exports.test_set_color = function () {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
timePicker.color = new color.Color("red");
TKUnit.assertEqual(timePicker.color.ios.CGColor, timePicker.ios.valueForKey("textColor").CGColor, "timePicker.color");
});

}
}

export function test_WhenCreated_HourIsUndefined() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
Expand Down
52 changes: 52 additions & 0 deletions ui/styling/stylers.ios.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -814,6 +814,56 @@ export class TabViewStyler implements definition.stylers.Styler {
}
}

export class DatePickerStyler implements definition.stylers.Styler {
// color
private static setColorProperty(view: view.View, newValue: any) {
var picker = <UIDatePicker>view._nativeView;
picker.setValueForKey(newValue, "textColor");
}

private static resetColorProperty(view: view.View, nativeValue: any) {
var picker = <UIDatePicker>view._nativeView;
picker.setValueForKey(nativeValue, "textColor");

vakrilov Nov 3, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There is no getColorProperty method so nativeValue here will be undefined. Will this cause an exception or just reset to default value?
}

private static getColorProperty(view: view.View): any {
var picker = <UIDatePicker>view._nativeView;
return picker.valueForKey("textColor");
}

public static registerHandlers() {
style.registerHandler(style.colorProperty, new stylersCommon.StylePropertyChangedHandler(
DatePickerStyler.setColorProperty,
DatePickerStyler.resetColorProperty,
DatePickerStyler.getColorProperty), "DatePicker");
}
}

export class TimePickerStyler implements definition.stylers.Styler {
// color
private static setColorProperty(view: view.View, newValue: any) {
var picker = <UIDatePicker>view._nativeView;
picker.setValueForKey(newValue, "textColor");
}

private static resetColorProperty(view: view.View, nativeValue: any) {
var picker = <UIDatePicker>view._nativeView;
picker.setValueForKey(nativeValue, "textColor");
}

private static getColorProperty(view: view.View): any {
var picker = <UIDatePicker>view._nativeView;
return picker.valueForKey("textColor");
}

public static registerHandlers() {
style.registerHandler(style.colorProperty, new stylersCommon.StylePropertyChangedHandler(
TimePickerStyler.setColorProperty,
TimePickerStyler.resetColorProperty,
TimePickerStyler.getColorProperty), "TimePicker");
}
}

function setTextAlignment(view: TextUIView, value: string) {
switch (value) {
case enums.TextAlignment.left:
Expand Down Expand Up @@ -846,4 +896,6 @@ export function _registerDefaultStylers() {
TextFieldStyler.registerHandlers();
ActivityIndicatorStyler.registerHandlers();
SliderStyler.registerHandlers();
DatePickerStyler.registerHandlers();
TimePickerStyler.registerHandlers();
}
Back | FazBrowse Home | New Git URL