FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ios): secureWithoutAutofill on TextField by NathanWalker · Pull Request #11129 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(ios): secureWithoutAutofill on TextField - #11129

Merged
NathanWalker merged 1 commit into
mainfrom
fix/ios-secureWithoutAutofill
Mar 4, 2026
ConversationCommits (1)ChecksFiles changed
Merged

fix(ios): secureWithoutAutofill on TextField#11129
NathanWalker merged 1 commit into
mainfrom
fix/ios-secureWithoutAutofill

Conversation

NathanWalker commented Mar 4, 2026

Copy link
Copy Markdown
Contributor
  • improves secureWithoutAutofill onTextField with iOS to ensure it applies at the right time to prevent the autofill handling

nx-cloud Bot commented Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit d3bd6e9

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 5m 52s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-04 19:23:30 UTC

NathanWalker merged commit 5347c7e into main Mar 4, 2026
6 of 7 checks passed
NathanWalker deleted the fix/ios-secureWithoutAutofill branch March 4, 2026 22:53
CatchABus reviewed Mar 4, 2026
View reviewed changes
Comment thread packages/core/ui/text-field/index.ios.ts
return;
}

const nativeField = textField as any;

CatchABus Mar 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is cast to any necessary here? I understand these props are available in UITextField.

NathanWalker Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some properties are sdk level scoped so we can probably rather use SDK_VERSION scope on some.

CatchABus reviewed Mar 4, 2026
View reviewed changes
Comment thread packages/core/ui/text-field/index.ios.ts
*/
textField.secureTextEntry = true;
}
this._applySecureWithoutAutofillTraits(textField);

CatchABus Mar 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe we need an extra flag to determine if the native props have already been updated and reduce _applySecureWithoutAutofillTraits calls since there are cases like reloadInputViews() that might be called multiple times while typing.
For instance, the old fix made sure to check whether secureTextEntry was already enabled or not before proceeding.

CatchABus reviewed Mar 5, 2026
View reviewed changes

CatchABus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I see the PR got merged but I'll leave a couple of comments here.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

CatchABus CatchABus left review comments
triniwiz triniwiz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL