fix(ios): scene notify first launch - #11149
Merged
NathanWalker merged 2 commits intoMar 30, 2026
Merged
Conversation
Copy link
Copy Markdown
|
View your CI Pipeline Execution ↗ for commit cdcbcb3
☁️ Nx Cloud last updated this comment at 2026-03-30 16:58:00 UTC |
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
Adjusts iOS scene-lifecycle startup logic so the “scene first launch” notification is emitted exactly once on initial app startup, even when the primary scene is assigned during scene setup.
Changes:
- Compute a isFirstScene flag before _setupWindowForScene can assign the primary scene.
- Gate _notifySceneAppStarted() on both “no primary scene yet” and “app not launched yet” to prevent duplicate launch notifications.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
CatchABus
approved these changes
Mar 30, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.