packages/core/ui/tab-view/index.ios.ts (2)

137-144: 💤 Low value

Consider adding a defensive check for moreNavigationControllerDelegate.

The code re-asserts the delegate to ensure callbacks reach the TabView, but doesn't verify that owner.moreNavigationControllerDelegate is non-null before assignment. While unlikely during an active tab selection callback, adding a check would align with the stated intent of "re-asserting" the delegate rather than potentially clearing it.

🛡️ Proposed defensive check

 // iOS lazily initializes moreNavigationController (e.g. on first access of
 // topViewController, or on first tap of the More tab) and can clear the
 // delegate we set in setViewControllers. Re-assert it whenever any tab is
 // selected so moreNav push/pop callbacks for tabs >= 5 still reach us.
 const moreNav = tabBarController.moreNavigationController;
-if (moreNav && moreNav.delegate !== owner.moreNavigationControllerDelegate) {
+if (moreNav && owner.moreNavigationControllerDelegate && moreNav.delegate !== owner.moreNavigationControllerDelegate) {
   moreNav.delegate = owner.moreNavigationControllerDelegate;
 }

---

606-606: ⚡ Quick win

Add null check on moreNavigationController for consistency.

Line 142 guards access to moreNavigationController with a null check, but this line doesn't. While accessing properties on nil in Objective-C is safe (no-op), adding a consistent check improves clarity and defensive programming, especially since moreNavigationController is nil when there are fewer than 5 tabs.

♻️ Proposed consistency fix

 // When we set this._ios.viewControllers, someone is clearing the moreNavigationController.delegate, so we have to reassign it each time here.
-this._ios.moreNavigationController.delegate = this.moreNavigationControllerDelegate;
+if (this._ios.moreNavigationController) {
+  this._ios.moreNavigationController.delegate = this.moreNavigationControllerDelegate;
+}

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 43fd6597-98a1-456b-98af-7fb25bcc3f08

Reviewing files that changed from the base of the PR and between 4070d91 and 3b803c9.

• packages/core/ui/tab-view/index.ios.ts