FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(core): complete `sideEffects` declarations for inspector modules, network requests in devtools by Copilot · Pull Request #11229 · NativeScript/NativeScript · GitHub

/ NativeScript Public

fix(core): complete sideEffects declarations for inspector modules, network requests in devtools - #11229

Merged
NathanWalker merged 2 commits into
mainfrom
copilot/update-sideeffects-array
May 27, 2026
ConversationCommits (2)ChecksFiles changed
Merged

fix(core): complete sideEffects declarations for inspector modules, network requests in devtools#11229
NathanWalker merged 2 commits into
mainfrom
copilot/update-sideeffects-array

Conversation

Copilot AI commented May 27, 2026 •
edited by NathanWalker
Loading

Copy link
Copy Markdown
Contributor

packages/core/package.json had incomplete sideEffects metadata, omitting inspector-related files that are loaded for debugging/runtime behavior which caused Network request inspector in devtools to not show all requests.

  • What changed

    • Updated packages/core/package.json sideEffects array to add:
      • ./inspector_modules.js
      • ./debugger/webinspector-*.js
    • Kept existing entries intact and order/style consistent with the current file.

  • Resulting manifest section

    "sideEffects": [
  "bundle-entry-points.js",
  "./globals/index.js",
  "./inspector_modules.js",
  "./debugger/webinspector-*.js",
  "./globals"
]

Network requests are now inspectable.

Copilot AI changed the title [WIP] Update sideEffects array in package.json to include missing entries core: complete sideEffects declarations for inspector modules May 27, 2026
Copilot AI requested a review from NathanWalker May 27, 2026 04:05
NathanWalker marked this pull request as ready for review May 27, 2026 04:08
NathanWalker changed the title core: complete sideEffects declarations for inspector modules fix(core): complete sideEffects declarations for inspector modules, network requests in devtools May 27, 2026

NathanWalker commented May 27, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai review

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 684015fe-f587-4ff6-876b-0945a4350f4d

📥 Commits

Reviewing files that changed from the base of the PR and between 2e42e4a and f166ccc.

📒 Files selected for processing (1)
  • packages/core/package.json
📝 Walkthrough

Walkthrough

The packages/core/package.json file is updated to expand the sideEffects configuration array. Two new glob patterns are added: ./inspector_modules.js and ./debugger/webinspector-*.js. These entries instruct bundlers to preserve these inspector and debugger modules during tree-shaking.

Changes

Inspector and Debugger Side Effects Declaration

Layer / File(s) Summary
sideEffects configuration for inspector modules
packages/core/package.json		 The sideEffects array is extended with ./inspector_modules.js and ./debugger/webinspector-*.js to ensure bundlers retain these inspector and web debugger modules during tree-shaking.

Suggested labels

♥ community PR

🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and specifically describes the main change: completing sideEffects declarations for inspector modules to fix network request visibility in devtools.
Description check ✅ Passed The description is comprehensive and directly related to the changeset, explaining the problem, the specific changes made to package.json, and the resulting fix with supporting evidence.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches 🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch copilot/update-sideeffects-array

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

NathanWalker merged commit c2789ba into main May 27, 2026
5 checks passed
NathanWalker deleted the copilot/update-sideeffects-array branch May 27, 2026 04:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

triniwiz triniwiz approved these changes
NathanWalker Awaiting requested review from NathanWalker

Assignees

NathanWalker

Copilot code review Copilot

Labels

♥ community PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL