FormattedString ignores font scale on Android — withFontScale hardcodes 1, AbsoluteSizeSpan skips scale multiply - #11349
Open
tsushanth wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…rdcodes 1, AbsoluteSizeSpan skips scale multiply
farfromrefug
approved these changes
Aug 13, 2026
Copy link
Copy Markdown
Contributor
|
This shouldn't be enough to scale spans the right way in most android devices and I know through trial. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Android font scale: withFontScale (and other with* mutators) now preserve/forward scale correctly; AbsoluteSizeSpan in setSpanModifiers now multiplies fontSize by fontScaleInternal
Found via automated repo scanning, fix written and reviewed before opening.