FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(vite): align the dev boot with 9.1 runtime contract by NathanWalker · Pull Request #11355 · NativeScript/NativeScript · GitHub

feat(vite): align the dev boot with 9.1 runtime contract - #11355

Merged
NathanWalker merged 1 commit into
mainfrom
feat/vite-runtime-contract
Aug 20, 2026
Merged

feat(vite): align the dev boot with 9.1 runtime contract#11355
NathanWalker merged 1 commit into
mainfrom
feat/vite-runtime-contract

Conversation

Copy link
Copy Markdown
Contributor

Support 9.1 runtime contract.

  • import-map keys are matched literally, module responses must carry a JavaScript MIME, unresolvable specifiers fail loudly, and the client owns every URL shape it hands the loader. The dev boot already fits that contract - bundle.mjs is a local ES module whose static graph is only the query-free /ns/core bridge URLs, so the pre-configure window is harmless - and this makes the remaining edges explicit:
    • Serve the dev server with appType 'custom' so Vite's SPA fallback can never answer a module request with index.html; a bad module path now fails as a plain 404 that names the URL instead of a MIME rejection.
    • Set the module headers on /ns/entry, the one module route that sent no Content-Type.
    • Load the framework client strategy through an absolute URL resolved from import.meta.url. A ../ specifier from a dev-served module made the runtime register the strategy under a non-canonical .../hmr/client/../frameworks/... key and fetch its closure through blocking synchronous requests outside the async graph walk.
    • Type createRequire/createPumpingRequire on the ns:module surface and document the pre-configure invariant in the entry emitter

nx-cloud Bot commented Aug 19, 2026
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 3ca922b

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 3m 59s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-19 04:26:44 UTC

NathanWalker added this to the 9.1 milestone Aug 19, 2026
NathanWalker merged commit a16d5bf into main Aug 20, 2026
8 checks passed
NathanWalker deleted the feat/vite-runtime-contract branch August 20, 2026 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL