FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(mobile-base): remove noisy logs on android by triniwiz · Pull Request #11359 · NativeScript/NativeScript · GitHub

/ NativeScript Public

chore(mobile-base): remove noisy logs on android #11359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
triniwiz wants to merge 1 commit into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
+0 −16
Conversation 1 Commits 1 Checks 7 Files changed 2
Open

chore(mobile-base): remove noisy logs on android #11359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .java  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
    • BoxShadowDrawable.java
    • Utils.java
6 changes: 0 additions & 6 deletions ...mobile-base/android/widgets/src/main/java/org/nativescript/widgets/BoxShadowDrawable.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,6 @@ private void _renderShadowLayers(int[] values) {

// apply insets that mimic offsets/spread to the shadowLayer
int inset = -spreadRadius;
Log.d(TAG, "Insets:"
+ "\n l: " + (inset + offsetX)
+ "\n t: " + (inset + offsetY)
+ "\n r: " + (inset - offsetX)
+ "\n b: " + (inset - offsetY)
);

int layerIndex = this.addLayer(shadowLayer);
this.setLayerInset(layerIndex,
Expand Down
10 changes: 0 additions & 10 deletions packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/Utils.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -302,20 +302,14 @@ public static void drawBoxShadow(View view, int[] values) {
if (android.os.Build.VERSION.SDK_INT < android.os.Build.VERSION_CODES.M) {
return;
}
Log.d("BoxShadowDrawable", "drawBoxShadow");

Drawable background = view.getBackground();
Drawable wrappedBg;

if (background != null) {
Log.d("BoxShadowDrawable", "current background is: " + background.getClass().getName());

if (background instanceof BoxShadowDrawable) {
wrappedBg = ((BoxShadowDrawable) background).getWrappedDrawable();

if (wrappedBg != null) {
Log.d("BoxShadowDrawable", "already a BoxShadowDrawable, getting wrapped drawable:" + wrappedBg.getClass().getName());
}
} else {
wrappedBg = background;
}
Expand All @@ -324,13 +318,9 @@ public static void drawBoxShadow(View view, int[] values) {
}

// replace background
Log.d("BoxShadowDrawable", "replacing background with new BoxShadowDrawable...");
view.setBackground(new BoxShadowDrawable(wrappedBg, values));

background = view.getBackground();
if (background != null) {
Log.d("BoxShadowDrawable", "new background is: " + background.getClass().getName());
}

int count = 0;
while (view.getParent() != null && view.getParent() instanceof ViewGroup) {
Expand Down
Loading
Back | FazBrowse Home | New Git URL