fix(vite): replace the browser preload helper before esbuild minifies it - #11425
Merged
NathanWalker merged 1 commit intoSep 10, 2026
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
View your CI Pipeline Execution ↗ for commit 7d8ead3
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at 2026-09-10 00:05:23 UTC |
Sorry, something went wrong.
Copy link
Copy Markdown
npm i https://pkg.pr.new/@nativescript/core@11425 npm i https://pkg.pr.new/@nativescript/vite@11425 npm i https://pkg.pr.new/@nativescript/webpack@11425 commit: 7d8ead3 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
dynamicImportPlugin replaces Vite's browser __vitePreload helper (which touches document and window) with a native one, but it does so from generateBundle using a literal regex on the identifier. With build.minify: 'esbuild' Vite's vite:esbuild-transpile plugin has already renamed __vitePreload in renderChunk, so the regex misses, the browser helper ships, and its window.dispatchEvent in the rejection path turns every failed dynamic import into ReferenceError: window is not defined with a misattributed stack. Details in #11423.
What is the new behavior?
The transform runs in renderChunk as an enforce: 'post' plugin. User post plugins run before buildPlugins.post (where the esbuild minifier lives), so the helper is still named when it is replaced. renderChunk returns null when nothing changed, so untouched chunks and already-transformed code are left alone. transformDynamicImports is unchanged.
Specs cover the plugin shape (post + renderChunk, no generateBundle), the replacement through renderChunk, and the no-op/idempotent return.
Verified with a real ns build ios of a blank Vue app with build.minify: 'esbuild': the emitted bundle contains the native helper and no vite:preloadError / document.createElement("link"); the published 8.0.5 bundle has the reverse. At runtime a deliberately failing import() now reports the real load error.
Fixes #11423.